Re: [PATCH RFC 20/32] python//qmp.py: assert sockfile is not None

2020-05-31 Thread Philippe Mathieu-Daudé
On 5/14/20 7:53 AM, John Snow wrote: > In truth, if you don't do this, you'll just get a TypeError > exception. Now, you'll get an AssertionError. > > Is this tangibly better? No. > Does mypy complain less? Yes. > > Signed-off-by: John Snow > --- > python/qemu/lib/qmp.py | 1 + > 1 file

Re: [PATCH RFC 20/32] python//qmp.py: assert sockfile is not None

2020-05-26 Thread Philippe Mathieu-Daudé
On 5/26/20 6:03 PM, Philippe Mathieu-Daudé wrote: > On 5/14/20 7:53 AM, John Snow wrote: >> In truth, if you don't do this, you'll just get a TypeError >> exception. Now, you'll get an AssertionError. >> >> Is this tangibly better? No. >> Does mypy complain less? Yes. >> >> Signed-off-by: John

Re: [PATCH RFC 20/32] python//qmp.py: assert sockfile is not None

2020-05-26 Thread Philippe Mathieu-Daudé
On 5/14/20 7:53 AM, John Snow wrote: > In truth, if you don't do this, you'll just get a TypeError > exception. Now, you'll get an AssertionError. > > Is this tangibly better? No. > Does mypy complain less? Yes. > > Signed-off-by: John Snow > --- > python/qemu/lib/qmp.py | 1 + > 1 file

[PATCH RFC 20/32] python//qmp.py: assert sockfile is not None

2020-05-14 Thread John Snow
In truth, if you don't do this, you'll just get a TypeError exception. Now, you'll get an AssertionError. Is this tangibly better? No. Does mypy complain less? Yes. Signed-off-by: John Snow --- python/qemu/lib/qmp.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/qemu/lib/qmp.py