Re: [PATCH V2 for-6.2 0/2] fixes for bdrv_co_block_status
On Thu, Feb 03, 2022 at 12:42:30PM +0100, Peter Lieven wrote: Am 01.02.22 um 15:39 schrieb Kevin Wolf: Am 13.01.2022 um 15:44 hat Peter Lieven geschrieben: V1->V2: Patch 1: Treat a hole just like an unallocated area. [Ilya] Patch 2: Apply workaround only for pre-Quincy librbd versions and ensure default striping and non child images. [Ilya] Peter Lieven (2): block/rbd: fix handling of holes in .bdrv_co_block_status block/rbd: workaround for ceph issue #53784 Thanks, applied to the block branch. Kevin Hi Kevin, thanks for taking care of this. I was a few days out of office. @Stefano: it seems Kevin addresses your comments that should have gone into a V3. Yep :-) Thanks, Stefano
Re: [PATCH V2 for-6.2 0/2] fixes for bdrv_co_block_status
Am 01.02.22 um 15:39 schrieb Kevin Wolf: > Am 13.01.2022 um 15:44 hat Peter Lieven geschrieben: >> V1->V2: >> Patch 1: Treat a hole just like an unallocated area. [Ilya] >> Patch 2: Apply workaround only for pre-Quincy librbd versions and >> ensure default striping and non child images. [Ilya] >> >> Peter Lieven (2): >> block/rbd: fix handling of holes in .bdrv_co_block_status >> block/rbd: workaround for ceph issue #53784 > Thanks, applied to the block branch. > > Kevin > Hi Kevin, thanks for taking care of this. I was a few days out of office. @Stefano: it seems Kevin addresses your comments that should have gone into a V3. Best, Peter
Re: [PATCH V2 for-6.2 0/2] fixes for bdrv_co_block_status
Am 13.01.2022 um 15:44 hat Peter Lieven geschrieben: > V1->V2: > Patch 1: Treat a hole just like an unallocated area. [Ilya] > Patch 2: Apply workaround only for pre-Quincy librbd versions and > ensure default striping and non child images. [Ilya] > > Peter Lieven (2): > block/rbd: fix handling of holes in .bdrv_co_block_status > block/rbd: workaround for ceph issue #53784 Thanks, applied to the block branch. Kevin
Re: [PATCH V2 for-6.2 0/2] fixes for bdrv_co_block_status
On Thu, Jan 20, 2022 at 10:19:27AM +0100, Peter Lieven wrote: Am 19.01.22 um 15:57 schrieb Stefano Garzarella: On Fri, Jan 14, 2022 at 11:58:40AM +0100, Ilya Dryomov wrote: On Thu, Jan 13, 2022 at 3:44 PM Peter Lieven wrote: V1->V2: Patch 1: Treat a hole just like an unallocated area. [Ilya] Patch 2: Apply workaround only for pre-Quincy librbd versions and ensure default striping and non child images. [Ilya] Peter Lieven (2): block/rbd: fix handling of holes in .bdrv_co_block_status block/rbd: workaround for ceph issue #53784 block/rbd.c | 52 +--- 1 file changed, 45 insertions(+), 7 deletions(-) -- 2.25.1 These patches have both "for-6.2" in the subject and Cc: qemu-sta...@nongnu.org in the description, which is a little confusing. Just want to clarify that they should go into master and be backported to 6.2. Yeah, a bit confusing. These are for 7.0, so @Kevin can these patches go with your tree? Yes, sorry, my fault. It should be 7.0 Don't worry :-) What about sending a v3 fixing the version tag (I think you can just remove for-6.2), the extra space in the comment, and the Fixes tag on patch 2? If you will send v3, remember to report the R-b/T-b tags received in this version from me and Ilya. Thanks, Stefano
Re: [PATCH V2 for-6.2 0/2] fixes for bdrv_co_block_status
Am 19.01.22 um 15:57 schrieb Stefano Garzarella: > On Fri, Jan 14, 2022 at 11:58:40AM +0100, Ilya Dryomov wrote: >> On Thu, Jan 13, 2022 at 3:44 PM Peter Lieven wrote: >>> >>> V1->V2: >>> Patch 1: Treat a hole just like an unallocated area. [Ilya] >>> Patch 2: Apply workaround only for pre-Quincy librbd versions and >>> ensure default striping and non child images. [Ilya] >>> >>> Peter Lieven (2): >>> block/rbd: fix handling of holes in .bdrv_co_block_status >>> block/rbd: workaround for ceph issue #53784 >>> >>> block/rbd.c | 52 +--- >>> 1 file changed, 45 insertions(+), 7 deletions(-) >>> >>> -- >>> 2.25.1 >>> >>> >> >> These patches have both "for-6.2" in the subject and >> Cc: qemu-sta...@nongnu.org in the description, which is a little >> confusing. Just want to clarify that they should go into master >> and be backported to 6.2. > > Yeah, a bit confusing. These are for 7.0, so @Kevin can these patches go with > your tree? Yes, sorry, my fault. It should be 7.0 Peter
Re: [PATCH V2 for-6.2 0/2] fixes for bdrv_co_block_status
On Fri, Jan 14, 2022 at 11:58:40AM +0100, Ilya Dryomov wrote: On Thu, Jan 13, 2022 at 3:44 PM Peter Lieven wrote: V1->V2: Patch 1: Treat a hole just like an unallocated area. [Ilya] Patch 2: Apply workaround only for pre-Quincy librbd versions and ensure default striping and non child images. [Ilya] Peter Lieven (2): block/rbd: fix handling of holes in .bdrv_co_block_status block/rbd: workaround for ceph issue #53784 block/rbd.c | 52 +--- 1 file changed, 45 insertions(+), 7 deletions(-) -- 2.25.1 These patches have both "for-6.2" in the subject and Cc: qemu-sta...@nongnu.org in the description, which is a little confusing. Just want to clarify that they should go into master and be backported to 6.2. Yeah, a bit confusing. These are for 7.0, so @Kevin can these patches go with your tree? I'd just add the fixes tag also in the patch 2. With that: Reviewed-by: Stefano Garzarella Thanks, Stefano
Re: [PATCH V2 for-6.2 0/2] fixes for bdrv_co_block_status
On Thu, Jan 13, 2022 at 3:44 PM Peter Lieven wrote: > > V1->V2: > Patch 1: Treat a hole just like an unallocated area. [Ilya] > Patch 2: Apply workaround only for pre-Quincy librbd versions and > ensure default striping and non child images. [Ilya] > > Peter Lieven (2): > block/rbd: fix handling of holes in .bdrv_co_block_status > block/rbd: workaround for ceph issue #53784 > > block/rbd.c | 52 +--- > 1 file changed, 45 insertions(+), 7 deletions(-) > > -- > 2.25.1 > > These patches have both "for-6.2" in the subject and Cc: qemu-sta...@nongnu.org in the description, which is a little confusing. Just want to clarify that they should go into master and be backported to 6.2. Reviewed-by: Ilya Dryomov Thanks, Ilya
[PATCH V2 for-6.2 0/2] fixes for bdrv_co_block_status
V1->V2: Patch 1: Treat a hole just like an unallocated area. [Ilya] Patch 2: Apply workaround only for pre-Quincy librbd versions and ensure default striping and non child images. [Ilya] Peter Lieven (2): block/rbd: fix handling of holes in .bdrv_co_block_status block/rbd: workaround for ceph issue #53784 block/rbd.c | 52 +--- 1 file changed, 45 insertions(+), 7 deletions(-) -- 2.25.1
