Re: [PATCH for-5.0] hw/ppc/ppc440_uc.c: Remove incorrect iothread locking from dcr_write_pcie()

2020-03-30 Thread David Gibson
On Mon, Mar 30, 2020 at 01:52:28PM +0100, Peter Maydell wrote: > In dcr_write_pcie() we take the iothread lock around a call to > pcie_host_mmcfg_udpate(). This is an incorrect attempt to deal with > the bug fixed in commit 235352ee6e73d7716, where we were not taking > the iothread lock before

Re: [PATCH for-5.0] hw/ppc/ppc440_uc.c: Remove incorrect iothread locking from dcr_write_pcie()

2020-03-30 Thread Peter Maydell
On Mon, 30 Mar 2020 at 14:17, BALATON Zoltan wrote: > > On Mon, 30 Mar 2020, Peter Maydell wrote: > > In dcr_write_pcie() we take the iothread lock around a call to > > pcie_host_mmcfg_udpate(). This is an incorrect attempt to deal with > > the bug fixed in commit 235352ee6e73d7716, where we

Re: [PATCH for-5.0] hw/ppc/ppc440_uc.c: Remove incorrect iothread locking from dcr_write_pcie()

2020-03-30 Thread BALATON Zoltan
On Mon, 30 Mar 2020, Peter Maydell wrote: In dcr_write_pcie() we take the iothread lock around a call to pcie_host_mmcfg_udpate(). This is an incorrect attempt to deal with the bug fixed in commit 235352ee6e73d7716, where we were not taking the iothread lock before calling device dcr read/write

[PATCH for-5.0] hw/ppc/ppc440_uc.c: Remove incorrect iothread locking from dcr_write_pcie()

2020-03-30 Thread Peter Maydell
In dcr_write_pcie() we take the iothread lock around a call to pcie_host_mmcfg_udpate(). This is an incorrect attempt to deal with the bug fixed in commit 235352ee6e73d7716, where we were not taking the iothread lock before calling device dcr read/write functions. (It's not sufficient locking,