Re: [PATCH for-5.1 2/5] qom: Plug memory leak in "info qom-tree"

2020-07-16 Thread Thomas Huth
On 15/07/2020 17.19, Li Qiang wrote: > Markus Armbruster 于2020年7月15日周三 上午12:05写道: >> >> Commit e8c9e65816 "qom: Make "info qom-tree" show children sorted" >> created a memory leak, because I didn't realize >> object_get_canonical_path_component()'s value needs to be freed. >> >> Reproducer: >> >>

Re: [PATCH for-5.1 2/5] qom: Plug memory leak in "info qom-tree"

2020-07-15 Thread Li Qiang
Markus Armbruster 于2020年7月15日周三 上午12:05写道: > > Commit e8c9e65816 "qom: Make "info qom-tree" show children sorted" > created a memory leak, because I didn't realize > object_get_canonical_path_component()'s value needs to be freed. > > Reproducer: > > $ qemu-system-x86_64 -nodefaults -display

Re: [PATCH for-5.1 2/5] qom: Plug memory leak in "info qom-tree"

2020-07-14 Thread Philippe Mathieu-Daudé
On 7/14/20 6:01 PM, Markus Armbruster wrote: > Commit e8c9e65816 "qom: Make "info qom-tree" show children sorted" > created a memory leak, because I didn't realize > object_get_canonical_path_component()'s value needs to be freed. > > Reproducer: > > $ qemu-system-x86_64 -nodefaults -display

Re: [PATCH for-5.1 2/5] qom: Plug memory leak in "info qom-tree"

2020-07-14 Thread Philippe Mathieu-Daudé
On 7/14/20 6:01 PM, Markus Armbruster wrote: > Commit e8c9e65816 "qom: Make "info qom-tree" show children sorted" > created a memory leak, because I didn't realize > object_get_canonical_path_component()'s value needs to be freed. > > Reproducer: > > $ qemu-system-x86_64 -nodefaults -display

[PATCH for-5.1 2/5] qom: Plug memory leak in "info qom-tree"

2020-07-14 Thread Markus Armbruster
Commit e8c9e65816 "qom: Make "info qom-tree" show children sorted" created a memory leak, because I didn't realize object_get_canonical_path_component()'s value needs to be freed. Reproducer: $ qemu-system-x86_64 -nodefaults -display none -S -monitor stdio QEMU 5.0.50 monitor - type