Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Jul 28, 2022 at 02:40:22PM +0100, Peter Maydell wrote: >> On Thu, 28 Jul 2022 at 14:30, Markus Armbruster wrote: >> > Peter Maydell writes: >> > I applaud the renaissance of roman-style inscriptions, but it's not just >> > words without spaces, it's also cap

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Daniel P . Berrangé
On Thu, Jul 28, 2022 at 02:40:22PM +0100, Peter Maydell wrote: > On Thu, 28 Jul 2022 at 14:30, Markus Armbruster wrote: > > Peter Maydell writes: > > I applaud the renaissance of roman-style inscriptions, but it's not just > > words without spaces, it's also capital letters only: > > > > ANY6

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Igor Mammedov
On Thu, 28 Jul 2022 15:29:58 +0200 Markus Armbruster wrote: > Peter Maydell writes: > > > On Thu, 28 Jul 2022 at 11:23, Daniel P. Berrangé > > wrote: > >> > >> On Thu, Jul 28, 2022 at 11:05:13AM +0100, Peter Maydell wrote: > >> > On Thu, 28 Jul 2022 at 10:48, Daniel P. Berrangé > >> > w

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Peter Maydell
On Thu, 28 Jul 2022 at 14:30, Markus Armbruster wrote: > Peter Maydell writes: > I applaud the renaissance of roman-style inscriptions, but it's not just > words without spaces, it's also capital letters only: > > ANY64CHARACTERFAKEOSKISENOUGHTOPREVENTINVALIDKEYWARNINGSONSTDERR > > Seriously,

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Markus Armbruster
Peter Maydell writes: > On Thu, 28 Jul 2022 at 11:23, Daniel P. Berrangé wrote: >> >> On Thu, Jul 28, 2022 at 11:05:13AM +0100, Peter Maydell wrote: >> > On Thu, 28 Jul 2022 at 10:48, Daniel P. Berrangé >> > wrote: >> > > >> > > On Thu, Jul 28, 2022 at 05:35:58AM -0400, Igor Mammedov wrote: >>

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Daniel P . Berrangé
On Thu, Jul 28, 2022 at 02:00:37PM +0200, Igor Mammedov wrote: > On Thu, 28 Jul 2022 11:23:00 +0100 > Daniel P. Berrangé wrote: > > > On Thu, Jul 28, 2022 at 11:05:13AM +0100, Peter Maydell wrote: > > > On Thu, 28 Jul 2022 at 10:48, Daniel P. Berrangé > > > wrote: > > > > > > > > On Thu, Jul

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Igor Mammedov
On Thu, 28 Jul 2022 11:23:00 +0100 Daniel P. Berrangé wrote: > On Thu, Jul 28, 2022 at 11:05:13AM +0100, Peter Maydell wrote: > > On Thu, 28 Jul 2022 at 10:48, Daniel P. Berrangé > > wrote: > > > > > > On Thu, Jul 28, 2022 at 05:35:58AM -0400, Igor Mammedov wrote: > > > > QEMU probably can'

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Igor Mammedov
On Thu, 28 Jul 2022 10:48:27 +0100 Daniel P. Berrangé wrote: > On Thu, Jul 28, 2022 at 05:35:58AM -0400, Igor Mammedov wrote: > > QEMU probably can't carry OSK key[1] for legal reasons so it > > can't supply the valid default key. However when tests are run > > applesmc will pollute test log with

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Peter Maydell
On Thu, 28 Jul 2022 at 11:23, Daniel P. Berrangé wrote: > > On Thu, Jul 28, 2022 at 11:05:13AM +0100, Peter Maydell wrote: > > On Thu, 28 Jul 2022 at 10:48, Daniel P. Berrangé > > wrote: > > > > > > On Thu, Jul 28, 2022 at 05:35:58AM -0400, Igor Mammedov wrote: > > > > QEMU probably can't carry

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Daniel P . Berrangé
On Thu, Jul 28, 2022 at 11:05:13AM +0100, Peter Maydell wrote: > On Thu, 28 Jul 2022 at 10:48, Daniel P. Berrangé wrote: > > > > On Thu, Jul 28, 2022 at 05:35:58AM -0400, Igor Mammedov wrote: > > > QEMU probably can't carry OSK key[1] for legal reasons so it > > > can't supply the valid default ke

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Peter Maydell
On Thu, 28 Jul 2022 at 10:48, Daniel P. Berrangé wrote: > > On Thu, Jul 28, 2022 at 05:35:58AM -0400, Igor Mammedov wrote: > > QEMU probably can't carry OSK key[1] for legal reasons so it > > can't supply the valid default key. However when tests are run > > applesmc will pollute test log with dis

Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Daniel P . Berrangé
On Thu, Jul 28, 2022 at 05:35:58AM -0400, Igor Mammedov wrote: > QEMU probably can't carry OSK key[1] for legal reasons so it > can't supply the valid default key. However when tests are run > applesmc will pollute test log with distracting warning, > silence that warning so it won't distract maint

[PATCH for-7.1] applesmc: silence invalid key warning in case default one is used

2022-07-28 Thread Igor Mammedov
QEMU probably can't carry OSK key[1] for legal reasons so it can't supply the valid default key. However when tests are run applesmc will pollute test log with distracting warning, silence that warning so it won't distract maintainers/CI. If user launches MacOS guest without supplying valid or any