Re: [PATCH for 7.1] linux-user: fix compat with glibc >= 2.36 sys/mount.h

2022-10-04 Thread Daniel P . Berrangé
On Mon, Oct 03, 2022 at 09:31:52AM +0100, Daniel P. Berrangé wrote: > On Sat, Oct 01, 2022 at 11:34:20PM +0200, Andreas Schwab wrote: > > On Aug 02 2022, Daniel P. Berrangé wrote: > > > > > This patch removes linux/fs.h, meaning we have to define > > > various FS_IOC constants that are now

Re: [PATCH for 7.1] linux-user: fix compat with glibc >= 2.36 sys/mount.h

2022-10-03 Thread Daniel P . Berrangé
On Sat, Oct 01, 2022 at 11:34:20PM +0200, Andreas Schwab wrote: > On Aug 02 2022, Daniel P. Berrangé wrote: > > > This patch removes linux/fs.h, meaning we have to define > > various FS_IOC constants that are now unavailable. > > This breaks a lot of ioctl emulations, as it lacks their

Re: [PATCH for 7.1] linux-user: fix compat with glibc >= 2.36 sys/mount.h

2022-10-01 Thread Andreas Schwab
On Aug 02 2022, Daniel P. Berrangé wrote: > This patch removes linux/fs.h, meaning we have to define > various FS_IOC constants that are now unavailable. This breaks a lot of ioctl emulations, as it lacks their definitions: #define BLKGETSIZE64 _IOR(0x12,114,size_t) #define

Re: [PATCH for 7.1] linux-user: fix compat with glibc >= 2.36 sys/mount.h

2022-08-10 Thread Laurent Vivier
Le 02/08/2022 à 18:41, Daniel P. Berrangé a écrit : The latest glibc 2.36 has extended sys/mount.h so that it defines the FSCONFIG_* enum constants. These are historically defined in linux/mount.h, and thus if you include both headers the compiler complains: In file included from

Re: [PATCH for 7.1] linux-user: fix compat with glibc >= 2.36 sys/mount.h

2022-08-10 Thread Daniel P . Berrangé
Laurent: ping, Can you consider queuing this so 7.1 isn't broken with latest glibc releases. On Tue, Aug 02, 2022 at 12:41:34PM -0400, Daniel P. Berrangé wrote: > The latest glibc 2.36 has extended sys/mount.h so that it > defines the FSCONFIG_* enum constants. These are historically > defined

Re: [PATCH for 7.1] linux-user: fix compat with glibc >= 2.36 sys/mount.h

2022-08-05 Thread Florian Weimer
* Daniel P. Berrangé: > CC'ing Florian to get the POV of a glibc maintainer on what we've > had to do to work around this compatibility brekage. Meh, that's really not great. 8-( I'll see if I can add a similar workaround to the glibc headers. Unfortunately I'm busy with other stuff right now,

Re: [PATCH for 7.1] linux-user: fix compat with glibc >= 2.36 sys/mount.h

2022-08-03 Thread Daniel P . Berrangé
CC'ing Florian to get the POV of a glibc maintainer on what we've had to do to work around this compatibility brekage. On Tue, Aug 02, 2022 at 12:41:34PM -0400, Daniel P. Berrangé wrote: > The latest glibc 2.36 has extended sys/mount.h so that it > defines the FSCONFIG_* enum constants. These are

Re: [PATCH for 7.1] linux-user: fix compat with glibc >= 2.36 sys/mount.h

2022-08-02 Thread Peter Maydell
On Tue, 2 Aug 2022 at 17:43, Daniel P. Berrangé wrote: > > The latest glibc 2.36 has extended sys/mount.h so that it > defines the FSCONFIG_* enum constants. These are historically > defined in linux/mount.h, and thus if you include both headers > the compiler complains: > > In file included from

Re: [PATCH for 7.1] linux-user: fix compat with glibc >= 2.36 sys/mount.h

2022-08-02 Thread Richard W.M. Jones
On Tue, Aug 02, 2022 at 07:29:29PM +0100, Richard W.M. Jones wrote: > Dan, which Fedora glibc package shows this problem? I have > glibc-2.35.9000-31.fc37.x86_64 and qemu compiled fine. (Also nbdkit > which includes linux/fs.h) It would help if I enabled a *-linux-user target ... Yes, I can

Re: [PATCH for 7.1] linux-user: fix compat with glibc >= 2.36 sys/mount.h

2022-08-02 Thread Richard W.M. Jones
On Tue, Aug 02, 2022 at 12:41:34PM -0400, Daniel P. Berrangé wrote: > The latest glibc 2.36 has extended sys/mount.h so that it > defines the FSCONFIG_* enum constants. These are historically > defined in linux/mount.h, and thus if you include both headers > the compiler complains: > > In file

[PATCH for 7.1] linux-user: fix compat with glibc >= 2.36 sys/mount.h

2022-08-02 Thread Daniel P . Berrangé
The latest glibc 2.36 has extended sys/mount.h so that it defines the FSCONFIG_* enum constants. These are historically defined in linux/mount.h, and thus if you include both headers the compiler complains: In file included from /usr/include/linux/fs.h:19, from