Re: [PATCH v1] qmp: don't hold ctx lock while querying blockstats

2020-07-10 Thread Kevin Wolf
Am 10.07.2020 um 10:54 hat Zhenyu Ye geschrieben: > Because the QMP command runs in the main thread, and changes > to the aio context of iothread will only be executed in the > main thread (they will not be in parallel), so there is no > need a lock protection while querying blockstats. > > If we

Re: [PATCH v1] qmp: don't hold ctx lock while querying blockstats

2020-07-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200710085400.343-1-yezhen...@huawei.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[PATCH v1] qmp: don't hold ctx lock while querying blockstats

2020-07-10 Thread Zhenyu Ye
Because the QMP command runs in the main thread, and changes to the aio context of iothread will only be executed in the main thread (they will not be in parallel), so there is no need a lock protection while querying blockstats. If we hold the lock here, while the I/O pressure is high in vm and