Re: [PATCH v1 1/4] virtio: introduce VIRTQUEUE_DEFUALT_SIZE instead of hardcoded constants

2020-02-03 Thread Denis Plotnikov
On 03.02.2020 15:51, Michael S. Tsirkin wrote: On Mon, Feb 03, 2020 at 03:17:07PM +0300, Denis Plotnikov wrote: On 30.01.2020 16:38, Michael S. Tsirkin wrote: On Wed, Jan 29, 2020 at 05:06:59PM +0300, Denis Plotnikov wrote: Signed-off-by: Denis Plotnikov I'm not sure what the point is.

Re: [PATCH v1 1/4] virtio: introduce VIRTQUEUE_DEFUALT_SIZE instead of hardcoded constants

2020-02-03 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 03:17:07PM +0300, Denis Plotnikov wrote: > > > On 30.01.2020 16:38, Michael S. Tsirkin wrote: > > On Wed, Jan 29, 2020 at 05:06:59PM +0300, Denis Plotnikov wrote: > > > Signed-off-by: Denis Plotnikov > > > > I'm not sure what the point is. It's more or less an accident

Re: [PATCH v1 1/4] virtio: introduce VIRTQUEUE_DEFUALT_SIZE instead of hardcoded constants

2020-02-03 Thread Denis Plotnikov
On 30.01.2020 16:38, Michael S. Tsirkin wrote: On Wed, Jan 29, 2020 at 05:06:59PM +0300, Denis Plotnikov wrote: Signed-off-by: Denis Plotnikov I'm not sure what the point is. It's more or less an accident that these two devices share the queue size, this constance makes no sense to me.

Re: [PATCH v1 1/4] virtio: introduce VIRTQUEUE_DEFUALT_SIZE instead of hardcoded constants

2020-02-03 Thread Denis Plotnikov
On 30.01.2020 17:56, Stefan Hajnoczi wrote: On Wed, Jan 29, 2020 at 06:55:18PM +0100, Cornelia Huck wrote: On Wed, 29 Jan 2020 17:06:59 +0300 Denis Plotnikov wrote: Signed-off-by: Denis Plotnikov --- hw/block/virtio-blk.c | 6 -- hw/scsi/virtio-scsi.c | 5 +++--

Re: [PATCH v1 1/4] virtio: introduce VIRTQUEUE_DEFUALT_SIZE instead of hardcoded constants

2020-01-30 Thread Stefan Hajnoczi
On Wed, Jan 29, 2020 at 06:55:18PM +0100, Cornelia Huck wrote: > On Wed, 29 Jan 2020 17:06:59 +0300 > Denis Plotnikov wrote: > > > Signed-off-by: Denis Plotnikov > > --- > > hw/block/virtio-blk.c | 6 -- > > hw/scsi/virtio-scsi.c | 5 +++-- > > include/hw/virtio/virtio.h | 1 + >

Re: [PATCH v1 1/4] virtio: introduce VIRTQUEUE_DEFUALT_SIZE instead of hardcoded constants

2020-01-30 Thread Michael S. Tsirkin
On Wed, Jan 29, 2020 at 05:06:59PM +0300, Denis Plotnikov wrote: > Signed-off-by: Denis Plotnikov I'm not sure what the point is. It's more or less an accident that these two devices share the queue size, this constance makes no sense to me. > --- > hw/block/virtio-blk.c | 6 -- >

Re: [PATCH v1 1/4] virtio: introduce VIRTQUEUE_DEFUALT_SIZE instead of hardcoded constants

2020-01-29 Thread Cornelia Huck
On Wed, 29 Jan 2020 17:06:59 +0300 Denis Plotnikov wrote: > Signed-off-by: Denis Plotnikov > --- > hw/block/virtio-blk.c | 6 -- > hw/scsi/virtio-scsi.c | 5 +++-- > include/hw/virtio/virtio.h | 1 + > 3 files changed, 8 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH v1 1/4] virtio: introduce VIRTQUEUE_DEFUALT_SIZE instead of hardcoded constants

2020-01-29 Thread Philippe Mathieu-Daudé
On 1/29/20 3:06 PM, Denis Plotnikov wrote: Signed-off-by: Denis Plotnikov typo VIRTQUEUE_DEFUALT_SIZE -> VIRTQUEUE_DEFAULT_SIZE in subject With subject fixed: Reviewed-by: Philippe Mathieu-Daudé --- hw/block/virtio-blk.c | 6 -- hw/scsi/virtio-scsi.c | 5 +++--

[PATCH v1 1/4] virtio: introduce VIRTQUEUE_DEFUALT_SIZE instead of hardcoded constants

2020-01-29 Thread Denis Plotnikov
Signed-off-by: Denis Plotnikov --- hw/block/virtio-blk.c | 6 -- hw/scsi/virtio-scsi.c | 5 +++-- include/hw/virtio/virtio.h | 1 + 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 09f46ed85f..72f935033f 100644 ---