Re: [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug

2021-01-18 Thread Greg Kurz
On Mon, 18 Jan 2021 12:12:03 +1100 David Gibson wrote: > On Fri, Jan 15, 2021 at 06:22:16PM +0100, Greg Kurz wrote: > > On Thu, 14 Jan 2021 15:06:28 -0300 > > Daniel Henrique Barboza wrote: > > > > > The only restriction we have when unplugging CPUs is to forbid unplug of > > > the boot cpu

Re: [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug

2021-01-18 Thread Daniel Henrique Barboza
On 1/17/21 10:18 PM, David Gibson wrote: On Fri, Jan 15, 2021 at 03:52:56PM -0300, Daniel Henrique Barboza wrote: On 1/15/21 2:22 PM, Greg Kurz wrote: On Thu, 14 Jan 2021 15:06:28 -0300 Daniel Henrique Barboza wrote: The only restriction we have when unplugging CPUs is to forbid unplug

Re: [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug

2021-01-17 Thread David Gibson
On Fri, Jan 15, 2021 at 03:52:56PM -0300, Daniel Henrique Barboza wrote: > > > On 1/15/21 2:22 PM, Greg Kurz wrote: > > On Thu, 14 Jan 2021 15:06:28 -0300 > > Daniel Henrique Barboza wrote: > > > > > The only restriction we have when unplugging CPUs is to forbid unplug of > > > the boot cpu

Re: [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug

2021-01-17 Thread David Gibson
On Fri, Jan 15, 2021 at 06:22:16PM +0100, Greg Kurz wrote: > On Thu, 14 Jan 2021 15:06:28 -0300 > Daniel Henrique Barboza wrote: > > > The only restriction we have when unplugging CPUs is to forbid unplug of > > the boot cpu core. spapr_core_unplug_possible() does not contemplate the > > I

Re: [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug

2021-01-15 Thread Daniel Henrique Barboza
On 1/15/21 2:22 PM, Greg Kurz wrote: On Thu, 14 Jan 2021 15:06:28 -0300 Daniel Henrique Barboza wrote: The only restriction we have when unplugging CPUs is to forbid unplug of the boot cpu core. spapr_core_unplug_possible() does not contemplate the I can't remember why this restriction

Re: [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug

2021-01-15 Thread Daniel Henrique Barboza
On 1/15/21 2:22 PM, Greg Kurz wrote: On Thu, 14 Jan 2021 15:06:28 -0300 Daniel Henrique Barboza wrote: The only restriction we have when unplugging CPUs is to forbid unplug of the boot cpu core. spapr_core_unplug_possible() does not contemplate the I can't remember why this restriction

Re: [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug

2021-01-15 Thread Daniel Henrique Barboza
On 1/15/21 2:22 PM, Greg Kurz wrote: On Thu, 14 Jan 2021 15:06:28 -0300 Daniel Henrique Barboza wrote: The only restriction we have when unplugging CPUs is to forbid unplug of the boot cpu core. spapr_core_unplug_possible() does not contemplate the I'll look into it. I can't remember

Re: [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug

2021-01-15 Thread Greg Kurz
On Thu, 14 Jan 2021 15:06:28 -0300 Daniel Henrique Barboza wrote: > The only restriction we have when unplugging CPUs is to forbid unplug of > the boot cpu core. spapr_core_unplug_possible() does not contemplate the I can't remember why this restriction was introduced in the first place... This

Re: [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug

2021-01-14 Thread David Gibson
On Thu, Jan 14, 2021 at 03:06:28PM -0300, Daniel Henrique Barboza wrote: > The only restriction we have when unplugging CPUs is to forbid unplug of > the boot cpu core. spapr_core_unplug_possible() does not contemplate the > possibility of some cores being offlined by the guest, meaning that we're

[PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug

2021-01-14 Thread Daniel Henrique Barboza
The only restriction we have when unplugging CPUs is to forbid unplug of the boot cpu core. spapr_core_unplug_possible() does not contemplate the possibility of some cores being offlined by the guest, meaning that we're rolling the dice regarding on whether we're unplugging the last online CPU