Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-04-03 Thread John Snow
On 4/3/20 4:57 AM, Max Reitz wrote: > On 02.04.20 20:27, John Snow wrote: > > [...] > >> Are we squared up for this series? I am actually not sure. > > As far as I’m concerned, yes. I just had this question on how to use mypy. Oh, whoops, Kevin's comment. I do want to address that one.

Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-04-03 Thread Max Reitz
On 02.04.20 20:27, John Snow wrote: [...] > Are we squared up for this series? I am actually not sure. As far as I’m concerned, yes. I just had this question on how to use mypy. Max signature.asc Description: OpenPGP digital signature

Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-04-03 Thread Kevin Wolf
Am 02.04.2020 um 20:27 hat John Snow geschrieben: > On 4/1/20 8:40 AM, Max Reitz wrote: > > On 31.03.20 19:39, Kevin Wolf wrote: > >> Am 31.03.2020 um 19:23 hat John Snow geschrieben: > >>> > >>> > >>> On 3/31/20 6:21 AM, Max Reitz wrote: > On 31.03.20 02:00, John Snow wrote: > > Minor

Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-04-02 Thread John Snow
On 4/1/20 8:40 AM, Max Reitz wrote: > On 31.03.20 19:39, Kevin Wolf wrote: >> Am 31.03.2020 um 19:23 hat John Snow geschrieben: >>> >>> >>> On 3/31/20 6:21 AM, Max Reitz wrote: On 31.03.20 02:00, John Snow wrote: > Minor cleanup for HMP functions; helps with line length and

Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-04-01 Thread Max Reitz
On 01.04.20 15:51, Kevin Wolf wrote: > Am 01.04.2020 um 14:28 hat Max Reitz geschrieben: >> On 31.03.20 16:00, Kevin Wolf wrote: >>> Am 31.03.2020 um 12:21 hat Max Reitz geschrieben: On 31.03.20 02:00, John Snow wrote: > Minor cleanup for HMP functions; helps with line length and

Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-04-01 Thread Kevin Wolf
Am 01.04.2020 um 14:28 hat Max Reitz geschrieben: > On 31.03.20 16:00, Kevin Wolf wrote: > > Am 31.03.2020 um 12:21 hat Max Reitz geschrieben: > >> On 31.03.20 02:00, John Snow wrote: > >>> Minor cleanup for HMP functions; helps with line length and consolidates > >>> HMP helpers through one

Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-04-01 Thread Max Reitz
On 01.04.20 14:28, Max Reitz wrote: > On 31.03.20 16:00, Kevin Wolf wrote: >> Am 31.03.2020 um 12:21 hat Max Reitz geschrieben: >>> On 31.03.20 02:00, John Snow wrote: Minor cleanup for HMP functions; helps with line length and consolidates HMP helpers through one implementation

Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-04-01 Thread Max Reitz
On 31.03.20 19:39, Kevin Wolf wrote: > Am 31.03.2020 um 19:23 hat John Snow geschrieben: >> >> >> On 3/31/20 6:21 AM, Max Reitz wrote: >>> On 31.03.20 02:00, John Snow wrote: Minor cleanup for HMP functions; helps with line length and consolidates HMP helpers through one implementation

Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-04-01 Thread Max Reitz
On 31.03.20 16:00, Kevin Wolf wrote: > Am 31.03.2020 um 12:21 hat Max Reitz geschrieben: >> On 31.03.20 02:00, John Snow wrote: >>> Minor cleanup for HMP functions; helps with line length and consolidates >>> HMP helpers through one implementation function. >>> >>> Although we are adding a

Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-03-31 Thread Kevin Wolf
Am 31.03.2020 um 19:23 hat John Snow geschrieben: > > > On 3/31/20 6:21 AM, Max Reitz wrote: > > On 31.03.20 02:00, John Snow wrote: > >> Minor cleanup for HMP functions; helps with line length and consolidates > >> HMP helpers through one implementation function. > >> > >> Although we are

Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-03-31 Thread John Snow
On 3/31/20 6:21 AM, Max Reitz wrote: > On 31.03.20 02:00, John Snow wrote: >> Minor cleanup for HMP functions; helps with line length and consolidates >> HMP helpers through one implementation function. >> >> Although we are adding a universal toggle to turn QMP logging on or off, >> many

Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-03-31 Thread Kevin Wolf
Am 31.03.2020 um 12:21 hat Max Reitz geschrieben: > On 31.03.20 02:00, John Snow wrote: > > Minor cleanup for HMP functions; helps with line length and consolidates > > HMP helpers through one implementation function. > > > > Although we are adding a universal toggle to turn QMP logging on or

Re: [PATCH v10 10/14] iotests: add hmp helper with logging

2020-03-31 Thread Max Reitz
On 31.03.20 02:00, John Snow wrote: > Minor cleanup for HMP functions; helps with line length and consolidates > HMP helpers through one implementation function. > > Although we are adding a universal toggle to turn QMP logging on or off, > many existing callers to hmp functions don't expect that

[PATCH v10 10/14] iotests: add hmp helper with logging

2020-03-30 Thread John Snow
Minor cleanup for HMP functions; helps with line length and consolidates HMP helpers through one implementation function. Although we are adding a universal toggle to turn QMP logging on or off, many existing callers to hmp functions don't expect that output to be logged, which causes quite a few