Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()

2019-10-24 Thread Tao Xu
On 10/24/2019 9:20 PM, Eduardo Habkost wrote: On Thu, Oct 24, 2019 at 10:54:57AM +0100, Daniel P. Berrangé wrote: On Sun, Oct 20, 2019 at 07:11:14PM +0800, Tao Xu wrote: To convert strings with time suffixes to numbers, support time unit are "ps" for picosecond, "ns" for nanosecond, "us" for

Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()

2019-10-24 Thread Eduardo Habkost
On Thu, Oct 24, 2019 at 10:54:57AM +0100, Daniel P. Berrangé wrote: > On Sun, Oct 20, 2019 at 07:11:14PM +0800, Tao Xu wrote: > > To convert strings with time suffixes to numbers, support time unit are > > "ps" for picosecond, "ns" for nanosecond, "us" for microsecond, "ms" > > for millisecond or

Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()

2019-10-24 Thread Daniel P . Berrangé
On Sun, Oct 20, 2019 at 07:11:14PM +0800, Tao Xu wrote: > To convert strings with time suffixes to numbers, support time unit are > "ps" for picosecond, "ns" for nanosecond, "us" for microsecond, "ms" > for millisecond or "s" for second. > > Signed-off-by: Tao Xu > --- > > No changes in v13. >

Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()

2019-10-23 Thread Tao Xu
On 10/23/2019 9:08 AM, Eduardo Habkost wrote: Hi, First of all, sorry for not reviewing this earlier. I thought other people were already looking at the first 4 patches. On Sun, Oct 20, 2019 at 07:11:14PM +0800, Tao Xu wrote: To convert strings with time suffixes to numbers, support time

Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()

2019-10-22 Thread Tao Xu
On 10/23/2019 9:13 AM, Eric Blake wrote: On 10/20/19 6:11 AM, Tao Xu wrote: To convert strings with time suffixes to numbers, support time unit are "ps" for picosecond, "ns" for nanosecond, "us" for microsecond, "ms" for millisecond or "s" for second. I haven't yet reviewed the patch itself,

Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()

2019-10-22 Thread Eric Blake
On 10/20/19 6:11 AM, Tao Xu wrote: To convert strings with time suffixes to numbers, support time unit are "ps" for picosecond, "ns" for nanosecond, "us" for microsecond, "ms" for millisecond or "s" for second. I haven't yet reviewed the patch itself, but my off-hand observation: picosecond

Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()

2019-10-22 Thread Eduardo Habkost
Hi, First of all, sorry for not reviewing this earlier. I thought other people were already looking at the first 4 patches. On Sun, Oct 20, 2019 at 07:11:14PM +0800, Tao Xu wrote: > To convert strings with time suffixes to numbers, support time unit are > "ps" for picosecond, "ns" for

[PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()

2019-10-20 Thread Tao Xu
To convert strings with time suffixes to numbers, support time unit are "ps" for picosecond, "ns" for nanosecond, "us" for microsecond, "ms" for millisecond or "s" for second. Signed-off-by: Tao Xu --- No changes in v13. --- include/qemu/cutils.h | 1 + util/cutils.c | 82