Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-29 Thread Roman Bolshakov
On Tue, Jan 25, 2022 at 01:14:27PM +0900, Akihiko Odaki wrote: > On Tue, Jan 25, 2022 at 8:00 AM Roman Bolshakov wrote: > > > > On Mon, Jan 24, 2022 at 08:14:31PM +, Peter Maydell wrote: > > > On Mon, 24 Jan 2022 at 17:49, Roman Bolshakov wrote: > > > > I'm not sure why blocks are

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-28 Thread Akihiko Odaki
On Fri, Jan 28, 2022 at 11:30 PM Vladislav Yaroshchuk wrote: > > > > пт, 21 янв. 2022 г. в 16:03, Akihiko Odaki : >> >> On Fri, Jan 21, 2022 at 9:19 PM Vladislav Yaroshchuk >> wrote: >> > >> > >> > чт, 20 янв. 2022 г. в 11:32, Roman Bolshakov : >> >> >> >> On Thu, Jan 13, 2022 at 08:22:14PM

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-28 Thread Vladislav Yaroshchuk
пт, 21 янв. 2022 г. в 16:03, Akihiko Odaki : > On Fri, Jan 21, 2022 at 9:19 PM Vladislav Yaroshchuk > wrote: > > > > > > чт, 20 янв. 2022 г. в 11:32, Roman Bolshakov : > >> > >> On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote: > >> > Create separate netdevs for each vmnet

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-25 Thread Christian Schoenebeck
On Dienstag, 25. Januar 2022 12:08:21 CET Akihiko Odaki wrote: > On Tue, Jan 25, 2022 at 7:32 PM Peter Maydell wrote: > > On Tue, 25 Jan 2022 at 04:14, Akihiko Odaki wrote: > > > I'm neutral about the decision. I think QEMU should avoid using > > > Objective-C code except for interactions with

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-25 Thread Akihiko Odaki
On Tue, Jan 25, 2022 at 7:32 PM Peter Maydell wrote: > > On Tue, 25 Jan 2022 at 04:14, Akihiko Odaki wrote: > > I'm neutral about the decision. I think QEMU should avoid using > > Objective-C code except for interactions with Apple's APIs, and .c is > > superior in terms of that as it would

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-25 Thread Peter Maydell
On Tue, 25 Jan 2022 at 04:14, Akihiko Odaki wrote: > I'm neutral about the decision. I think QEMU should avoid using > Objective-C code except for interactions with Apple's APIs, and .c is > superior in terms of that as it would prevent accidental introduction > of Objective-C code. On the other

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-24 Thread Akihiko Odaki
On Tue, Jan 25, 2022 at 8:00 AM Roman Bolshakov wrote: > > On Mon, Jan 24, 2022 at 08:14:31PM +, Peter Maydell wrote: > > On Mon, 24 Jan 2022 at 17:49, Roman Bolshakov wrote: > > > I'm not sure why blocks are Objective-C specific. All the data I have > > > shows the opposite [3][4][5].

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-24 Thread Roman Bolshakov
On Mon, Jan 24, 2022 at 08:14:31PM +, Peter Maydell wrote: > On Mon, 24 Jan 2022 at 17:49, Roman Bolshakov wrote: > > I'm not sure why blocks are Objective-C specific. All the data I have > > shows the opposite [3][4][5]. They're just extensively used in Apple APIs. > > This is true, but for

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-24 Thread Christian Schoenebeck
On Montag, 24. Januar 2022 18:49:53 CET Roman Bolshakov wrote: > On Mon, Jan 24, 2022 at 12:27:40PM +0100, Christian Schoenebeck wrote: > > On Montag, 24. Januar 2022 10:56:00 CET Roman Bolshakov wrote: > > > On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote: > > > >

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-24 Thread Peter Maydell
On Mon, 24 Jan 2022 at 17:49, Roman Bolshakov wrote: > I'm not sure why blocks are Objective-C specific. All the data I have > shows the opposite [3][4][5]. They're just extensively used in Apple APIs. This is true, but for the purposes of our build machinery it is simpler to have three types of

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-24 Thread Roman Bolshakov
On Mon, Jan 24, 2022 at 12:27:40PM +0100, Christian Schoenebeck wrote: > On Montag, 24. Januar 2022 10:56:00 CET Roman Bolshakov wrote: > > On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote: > > > net/vmnet-bridged.m | 25 + > > > net/vmnet-common.m | 20 +++ > >

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-24 Thread Christian Schoenebeck
On Montag, 24. Januar 2022 10:56:00 CET Roman Bolshakov wrote: > On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote: > > Create separate netdevs for each vmnet operating mode: > > - vmnet-host > > - vmnet-shared > > - vmnet-bridged > > > > Signed-off-by: Vladislav Yaroshchuk >

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-24 Thread Roman Bolshakov
On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote: > Create separate netdevs for each vmnet operating mode: > - vmnet-host > - vmnet-shared > - vmnet-bridged > > Signed-off-by: Vladislav Yaroshchuk > --- > net/clients.h | 11 > net/meson.build | 7 +++ >

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-21 Thread Akihiko Odaki
On Fri, Jan 21, 2022 at 9:19 PM Vladislav Yaroshchuk wrote: > > > чт, 20 янв. 2022 г. в 11:32, Roman Bolshakov : >> >> On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote: >> > Create separate netdevs for each vmnet operating mode: >> > - vmnet-host >> > - vmnet-shared >> > -

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-21 Thread Vladislav Yaroshchuk
чт, 20 янв. 2022 г. в 11:32, Roman Bolshakov : > On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote: > > Create separate netdevs for each vmnet operating mode: > > - vmnet-host > > - vmnet-shared > > - vmnet-bridged > > > > Sure I'm late to the party but what if we add only one

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-20 Thread Roman Bolshakov
On Thu, Jan 13, 2022 at 08:22:14PM +0300, Vladislav Yaroshchuk wrote: > Create separate netdevs for each vmnet operating mode: > - vmnet-host > - vmnet-shared > - vmnet-bridged > Sure I'm late to the party but what if we add only one backend - vmnet with default mode set to shared and all

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-18 Thread Vladislav Yaroshchuk
вт, 18 янв. 2022 г. в 19:35, Markus Armbruster : > Vladislav Yaroshchuk writes: > > > вт, 18 янв. 2022 г. в 18:01, Markus Armbruster : > > > >> Vladislav Yaroshchuk writes: > >> > >> > Create separate netdevs for each vmnet operating mode: > >> > - vmnet-host > >> > - vmnet-shared > >> > -

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-18 Thread Vladislav Yaroshchuk
вт, 18 янв. 2022 г. в 18:01, Markus Armbruster : > Vladislav Yaroshchuk writes: > > > Create separate netdevs for each vmnet operating mode: > > - vmnet-host > > - vmnet-shared > > - vmnet-bridged > > > > Signed-off-by: Vladislav Yaroshchuk > > I acked v8 of the QAPI schema part. You should

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-18 Thread Markus Armbruster
Vladislav Yaroshchuk writes: > вт, 18 янв. 2022 г. в 18:01, Markus Armbruster : > >> Vladislav Yaroshchuk writes: >> >> > Create separate netdevs for each vmnet operating mode: >> > - vmnet-host >> > - vmnet-shared >> > - vmnet-bridged >> > >> > Signed-off-by: Vladislav Yaroshchuk >> >> I

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-18 Thread Markus Armbruster
Vladislav Yaroshchuk writes: > Create separate netdevs for each vmnet operating mode: > - vmnet-host > - vmnet-shared > - vmnet-bridged > > Signed-off-by: Vladislav Yaroshchuk I acked v8 of the QAPI schema part. You should add Acked-by and Reviewed-by you receive in later revisions, unless

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-15 Thread Vladislav Yaroshchuk
Hi Akihiko, Thank you for the review! I will fix the problems and resubmit as v14. --- Best regards, Vladislav Yaroshchuk пт, 14 янв. 2022 г. в 11:43, Akihiko Odaki : > Hi, > > Thank you for fixing the feature availability check. > > I decided to just check the series thoroughly before adding

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-14 Thread Akihiko Odaki
Hi, Thank you for fixing the feature availability check. I decided to just check the series thoroughly before adding Reviewed-By, and unfortunately ended up finding minor memory leaks and style problems. I'm sorry for adding comments so late. Particulalry, his patch has several 2-space

[PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-13 Thread Vladislav Yaroshchuk
Create separate netdevs for each vmnet operating mode: - vmnet-host - vmnet-shared - vmnet-bridged Signed-off-by: Vladislav Yaroshchuk --- net/clients.h | 11 net/meson.build | 7 +++ net/net.c | 10 net/vmnet-bridged.m | 25 + net/vmnet-common.m |