Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread David Hildenbrand
> The other thing to keep in mind is that the poison value only really > comes into play with hinting/reporting. In the case of the standard > balloon the pages are considered allocated from the guest's Currently just as free page hinting IMHO. They are temporarily considered allocated. >

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread Alexander Duyck
On Thu, Apr 16, 2020 at 7:55 AM David Hildenbrand wrote: > > >> We should document our result of page poisoning, free page hinting, and > >> free page reporting there as well. I hope you'll have time for the latter. > >> > >>

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread David Hildenbrand
>> We should document our result of page poisoning, free page hinting, and >> free page reporting there as well. I hope you'll have time for the latter. >> >> - >> Semantics of VIRTIO_BALLOON_F_PAGE_POISON >>

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread Michael S. Tsirkin
On Thu, Apr 16, 2020 at 10:18:49AM +0200, David Hildenbrand wrote: > >> > >> Postcopy is a very good point, bought! > >> > >> But (what you wrote above) it sounds like that this is really what we > >> *have to* do, not an optimization. I‘ll double check the spec tomorrow > >> (hopefully it was

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread David Hildenbrand
On 16.04.20 10:18, David Hildenbrand wrote: >>> >>> Postcopy is a very good point, bought! >>> >>> But (what you wrote above) it sounds like that this is really what we *have >>> to* do, not an optimization. I‘ll double check the spec tomorrow (hopefully >>> it was documented). We should

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread David Hildenbrand
>> >> Postcopy is a very good point, bought! >> >> But (what you wrote above) it sounds like that this is really what we *have >> to* do, not an optimization. I‘ll double check the spec tomorrow (hopefully >> it was documented). We should rephrase the comment then. > > Do you have a link to the

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-15 Thread Alexander Duyck
On Wed, Apr 15, 2020 at 12:46 PM David Hildenbrand wrote: > > > > > Am 15.04.2020 um 21:29 schrieb Alexander Duyck : > > > > On Wed, Apr 15, 2020 at 11:17 AM David Hildenbrand > > wrote: > >> > >>> > >>> The comment above explains the "why". Basically poisoning a page will > >>> dirty it. So

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-15 Thread David Hildenbrand
> Am 15.04.2020 um 21:29 schrieb Alexander Duyck : > > On Wed, Apr 15, 2020 at 11:17 AM David Hildenbrand wrote: >> >>> >>> The comment above explains the "why". Basically poisoning a page will >>> dirty it. So why hint a page as free when that will drop it back into >>> the guest and

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-15 Thread Alexander Duyck
On Wed, Apr 15, 2020 at 11:17 AM David Hildenbrand wrote: > > > > > The comment above explains the "why". Basically poisoning a page will > > dirty it. So why hint a page as free when that will drop it back into > > the guest and result in it being dirtied again. What you end up with > > is all

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-15 Thread David Hildenbrand
> > The comment above explains the "why". Basically poisoning a page will > dirty it. So why hint a page as free when that will drop it back into > the guest and result in it being dirtied again. What you end up with > is all the pages that were temporarily placed in the balloon are dirty > after

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-15 Thread Alexander Duyck
On Wed, Apr 15, 2020 at 1:08 AM David Hildenbrand wrote: > > On 10.04.20 05:41, Alexander Duyck wrote: > > From: Alexander Duyck > > > > We need to make certain to advertise support for page poison tracking if > > we want to actually get data on if the guest will be poisoning pages. So > > if

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-15 Thread David Hildenbrand
On 10.04.20 05:41, Alexander Duyck wrote: > From: Alexander Duyck > > We need to make certain to advertise support for page poison tracking if > we want to actually get data on if the guest will be poisoning pages. So > if free page hinting is active we should add page poisoning support and >

[PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-09 Thread Alexander Duyck
From: Alexander Duyck We need to make certain to advertise support for page poison tracking if we want to actually get data on if the guest will be poisoning pages. So if free page hinting is active we should add page poisoning support and let the guest disable it if it isn't using it. Page