Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

Paolo Bonzini writes: > On 15/06/20 07:17, Thomas Huth wrote: >> That depends ... Marc-André, Paolo, what's the status of the meson patch >> series? Do you think it will be merged for the next release already? If >> so, it does not make much sense to respin my distclean patch. Otherwise >> I

Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

On 15/06/2020 09.13, Paolo Bonzini wrote: > On 15/06/20 07:17, Thomas Huth wrote: >> That depends ... Marc-André, Paolo, what's the status of the meson patch >> series? Do you think it will be merged for the next release already? If >> so, it does not make much sense to respin my distclean patch.

Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

On 15/06/20 07:17, Thomas Huth wrote: > That depends ... Marc-André, Paolo, what's the status of the meson patch > series? Do you think it will be merged for the next release already? If > so, it does not make much sense to respin my distclean patch. Otherwise > I could do another iteration... I

Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

On 13/06/2020 18.28, Aleksandar Markovic wrote: > On Tue, Oct 8, 2019 at 2:41 PM Peter Maydell wrote: >> >> On Tue, 8 Oct 2019 at 13:37, Thomas Huth wrote: >>> >>> On 08/10/2019 14.18, Aleksandar Markovic wrote: If I remember well, QAPI-related c files are generated while doing 'make'.

Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

On Tue, Oct 8, 2019 at 2:41 PM Peter Maydell wrote: > > On Tue, 8 Oct 2019 at 13:37, Thomas Huth wrote: > > > > On 08/10/2019 14.18, Aleksandar Markovic wrote: > > > If I remember well, QAPI-related c files are generated while doing > > > 'make'. If that is true, these files should be deleted by

Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

- Original Message - > From: "Aleksandar Markovic" > Sent: Tuesday, October 22, 2019 10:35:51 PM > > On Tuesday, October 8, 2019, Thomas Huth wrote: > > > When running "make distclean" we currently leave a lot of generated > > files in the build directory. These should be completely

Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

On Tuesday, October 8, 2019, Thomas Huth wrote: > When running "make distclean" we currently leave a lot of generated > files in the build directory. These should be completely removed. > Some of the generated files are removed in the "clean" target (which > is a prerequisite for the "distclean"

Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

Daniel P. Berrangé writes: > Given that we're aiming to convert to meson, how much effort do we really > want to put into fixing this inconsistency ? > > I'd argue the best way to fix "clean" and "distclean" is to delete them > entirely. Instead enforce that builddir != srcdir when running

Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

On 08/10/19 14:41, Peter Maydell wrote: > The autoconf manual suggests some heuristics: > - If make built it, and it is commonly something that one would want >to rebuild (for instance, a .o file), then mostlyclean should delete it. > - Otherwise, if make built it, then clean should delete

Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

On 08/10/2019 14.41, Daniel P. Berrangé wrote: > On Tue, Oct 08, 2019 at 02:35:20PM +0200, Thomas Huth wrote: >> On 08/10/2019 14.18, Aleksandar Markovic wrote: >>> >>> >>> On Tuesday, October 8, 2019, Thomas Huth >> > wrote: >>> >>> When running "make distclean" we

Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

On Tue, 8 Oct 2019 at 13:37, Thomas Huth wrote: > > On 08/10/2019 14.18, Aleksandar Markovic wrote: > > If I remember well, QAPI-related c files are generated while doing > > 'make'. If that is true, these files should be deleted by 'make clean', > > shouldn't they? > > I think that's a

Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

On Tue, Oct 08, 2019 at 02:35:20PM +0200, Thomas Huth wrote: > On 08/10/2019 14.18, Aleksandar Markovic wrote: > > > > > > On Tuesday, October 8, 2019, Thomas Huth > > wrote: > > > > When running "make distclean" we currently leave a lot of generated > > files

Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

On 08/10/2019 14.18, Aleksandar Markovic wrote: > > > On Tuesday, October 8, 2019, Thomas Huth > wrote: > > When running "make distclean" we currently leave a lot of generated > files in the build directory. These should be completely removed. > Some of the

[PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

On Tuesday, October 8, 2019, Thomas Huth wrote: > When running "make distclean" we currently leave a lot of generated > files in the build directory. These should be completely removed. > Some of the generated files are removed in the "clean" target (which > is a prerequisite for the "distclean"

[PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

When running "make distclean" we currently leave a lot of generated files in the build directory. These should be completely removed. Some of the generated files are removed in the "clean" target (which is a prerequisite for the "distclean" target), since binary files should be removed in this