Re: [PATCH v2] block: drop BLK_PERM_GRAPH_MOD

2022-01-12 Thread Kevin Wolf
Am 02.09.2021 um 11:37 hat Vladimir Sementsov-Ogievskiy geschrieben: > First, this permission never protected a node from being changed, as > generic child-replacing functions don't check it. > > Second, it's a strange thing: it presents a permission of parent node > to change its child. But

Re: [PATCH v2] block: drop BLK_PERM_GRAPH_MOD

2021-12-18 Thread Vladimir Sementsov-Ogievskiy
Ping) 03.09.2021 21:47, Eric Blake wrote: On Thu, Sep 02, 2021 at 12:37:54PM +0300, Vladimir Sementsov-Ogievskiy wrote: First, this permission never protected a node from being changed, as generic child-replacing functions don't check it. Second, it's a strange thing: it presents a permission

Re: [PATCH v2] block: drop BLK_PERM_GRAPH_MOD

2021-09-22 Thread Vladimir Sementsov-Ogievskiy
Ping) Patch is reviewed. 02.09.2021 12:37, Vladimir Sementsov-Ogievskiy wrote: First, this permission never protected a node from being changed, as generic child-replacing functions don't check it. Second, it's a strange thing: it presents a permission of parent node to change its child. But

Re: [PATCH v2] block: drop BLK_PERM_GRAPH_MOD

2021-09-03 Thread Eric Blake
On Thu, Sep 02, 2021 at 12:37:54PM +0300, Vladimir Sementsov-Ogievskiy wrote: > First, this permission never protected a node from being changed, as > generic child-replacing functions don't check it. > > Second, it's a strange thing: it presents a permission of parent node > to change its child.

[PATCH v2] block: drop BLK_PERM_GRAPH_MOD

2021-09-02 Thread Vladimir Sementsov-Ogievskiy
First, this permission never protected a node from being changed, as generic child-replacing functions don't check it. Second, it's a strange thing: it presents a permission of parent node to change its child. But generally, children are replaced by different mechanisms, like jobs or qmp