Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-12-02 Thread Jonathan Cameron
On Wed, 2 Dec 2020 05:02:57 -0500 "Michael S. Tsirkin" wrote: > On Wed, Nov 25, 2020 at 02:56:59PM +, Jonathan Cameron wrote: > > Cool. I'll run a few more comprehensive tests then send out the > > trivial patch to enable the kernel option + v2 of the qemu support. > > IIUC there will be

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-12-02 Thread Michael S. Tsirkin
On Wed, Nov 25, 2020 at 02:56:59PM +, Jonathan Cameron wrote: > Cool. I'll run a few more comprehensive tests then send out the > trivial patch to enable the kernel option + v2 of the qemu support. IIUC there will be another version of this patch, right? -- MST

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-25 Thread David Hildenbrand
On 25.11.20 17:11, Jonathan Cameron wrote: > On Wed, 25 Nov 2020 16:54:53 +0100 > David Hildenbrand wrote: > >> >> 64k guest on 4k host with 512MiB block size seems fine. >> >> If there are any places anyone thinks need particular poking I'd >> appreciate a hint :) >

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-25 Thread Jonathan Cameron
On Wed, 25 Nov 2020 16:54:53 +0100 David Hildenbrand wrote: > > 64k guest on 4k host with 512MiB block size seems fine. > > If there are any places anyone thinks need particular poking I'd > appreciate a hint :) > >>> > >>> If things seem to work for now, that's

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-25 Thread David Hildenbrand
64k guest on 4k host with 512MiB block size seems fine. If there are any places anyone thinks need particular poking I'd appreciate a hint :) >>> >>> If things seem to work for now, that's great :) Thanks! >>> >> Cool. I'll run a few more comprehensive tests then send

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-25 Thread David Hildenbrand
> Ah. I'd missed that quirk around MAX_ORDER. It's also true of ARM64 with > 4k pages. As you can probably guess I'd forgotten to recompile my 4k test > kernel after adding that particular check. :( > > Ah well. Given we are already in a situation where adding 2MiB doesn't > actually > do

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-25 Thread Jonathan Cameron
On Tue, 24 Nov 2020 20:17:35 +0100 David Hildenbrand wrote: > On 24.11.20 19:11, Jonathan Cameron wrote: > > On Mon, 9 Nov 2020 20:47:09 +0100 > > David Hildenbrand wrote: > > > > +CC Eric based on similar query in other branch of the thread. > > > >> On 05.11.20 18:43, Jonathan Cameron

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-25 Thread David Hildenbrand
On 25.11.20 11:47, Andrew Jones wrote: > On Wed, Nov 25, 2020 at 09:45:19AM +0100, David Hildenbrand wrote: >> On 25.11.20 09:38, Andrew Jones wrote: >>> On Tue, Nov 24, 2020 at 08:17:35PM +0100, David Hildenbrand wrote: On 24.11.20 19:11, Jonathan Cameron wrote: > On Mon, 9 Nov 2020

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-25 Thread Andrew Jones
On Wed, Nov 25, 2020 at 09:45:19AM +0100, David Hildenbrand wrote: > On 25.11.20 09:38, Andrew Jones wrote: > > On Tue, Nov 24, 2020 at 08:17:35PM +0100, David Hildenbrand wrote: > >> On 24.11.20 19:11, Jonathan Cameron wrote: > >>> On Mon, 9 Nov 2020 20:47:09 +0100 > >>> David Hildenbrand wrote:

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-25 Thread David Hildenbrand
On 25.11.20 09:38, Andrew Jones wrote: > On Tue, Nov 24, 2020 at 08:17:35PM +0100, David Hildenbrand wrote: >> On 24.11.20 19:11, Jonathan Cameron wrote: >>> On Mon, 9 Nov 2020 20:47:09 +0100 >>> David Hildenbrand wrote: >>> >>> +CC Eric based on similar query in other branch of the thread. >>>

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-25 Thread Andrew Jones
On Tue, Nov 24, 2020 at 08:17:35PM +0100, David Hildenbrand wrote: > On 24.11.20 19:11, Jonathan Cameron wrote: > > On Mon, 9 Nov 2020 20:47:09 +0100 > > David Hildenbrand wrote: > > > > +CC Eric based on similar query in other branch of the thread. > > > >> On 05.11.20 18:43, Jonathan Cameron

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-24 Thread David Hildenbrand
On 24.11.20 19:11, Jonathan Cameron wrote: > On Mon, 9 Nov 2020 20:47:09 +0100 > David Hildenbrand wrote: > > +CC Eric based on similar query in other branch of the thread. > >> On 05.11.20 18:43, Jonathan Cameron wrote: >>> Basically a cut and paste job from the x86 support with the exception

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-24 Thread Jonathan Cameron
On Mon, 9 Nov 2020 20:47:09 +0100 David Hildenbrand wrote: +CC Eric based on similar query in other branch of the thread. > On 05.11.20 18:43, Jonathan Cameron wrote: > > Basically a cut and paste job from the x86 support with the exception of > > needing a larger block size as the Memory Block

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-09 Thread David Hildenbrand
On 05.11.20 18:43, Jonathan Cameron wrote: Basically a cut and paste job from the x86 support with the exception of needing a larger block size as the Memory Block Size (MIN_SECTION_SIZE) on ARM64 in Linux is 1G. Tested: * In full emulation and with KVM on an arm64 server. * cold and hotplug

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-09 Thread Auger Eric
Hi Jonathan, On 11/5/20 6:43 PM, Jonathan Cameron wrote: > Basically a cut and paste job from the x86 support with the exception of > needing a larger block size as the Memory Block Size (MIN_SECTION_SIZE) > on ARM64 in Linux is 1G. > > Tested: > * In full emulation and with KVM on an arm64

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-05 Thread Philippe Mathieu-Daudé
Cc'ing Igor. On 11/5/20 6:43 PM, Jonathan Cameron wrote: > Basically a cut and paste job from the x86 support with the exception of > needing a larger block size as the Memory Block Size (MIN_SECTION_SIZE) > on ARM64 in Linux is 1G. > > Tested: > * In full emulation and with KVM on an arm64

[PATCH v2] hw/arm/virt enable support for virtio-mem

2020-11-05 Thread Jonathan Cameron
Basically a cut and paste job from the x86 support with the exception of needing a larger block size as the Memory Block Size (MIN_SECTION_SIZE) on ARM64 in Linux is 1G. Tested: * In full emulation and with KVM on an arm64 server. * cold and hotplug for the virtio-mem-pci device. * Wide range of