Re: [PATCH v2] pc: add property for Linux setup_data random number seed

2022-08-05 Thread Paolo Bonzini
On 8/5/22 09:01, Michael S. Tsirkin wrote: -if (!legacy_no_rng_seed) { +if (x86ms->linuxboot_randomness != ON_OFF_AUTO_OFF && +(protocol >= 0x209 || x86ms->linuxboot_randomness == ON_OFF_AUTO_ON)) { Hmm so if user requested "on" but protocol is too old then we just ignore it sile

Re: [PATCH v2] pc: add property for Linux setup_data random number seed

2022-08-05 Thread Michael S. Tsirkin
On Fri, Aug 05, 2022 at 10:16:37AM +0200, Paolo Bonzini wrote: > On 8/5/22 09:01, Michael S. Tsirkin wrote: > > > -if (!legacy_no_rng_seed) { > > > +if (x86ms->linuxboot_randomness != ON_OFF_AUTO_OFF && > > > +(protocol >= 0x209 || x86ms->linuxboot_randomness == > > > ON_OFF_AUTO_O

Re: [PATCH v2] pc: add property for Linux setup_data random number seed

2022-08-05 Thread Michael S. Tsirkin
On Thu, Aug 04, 2022 at 11:24:41PM +0200, Paolo Bonzini wrote: > Using a property makes it possible to use the normal compat property > mechanism instead of ad hoc code; it avoids parameter proliferation > in x86_load_linux; and allows shipping the code even if it is > disabled by default. > > Cc:

[PATCH v2] pc: add property for Linux setup_data random number seed

2022-08-04 Thread Paolo Bonzini
Using a property makes it possible to use the normal compat property mechanism instead of ad hoc code; it avoids parameter proliferation in x86_load_linux; and allows shipping the code even if it is disabled by default. Cc: Michael S. Tsirkin Co-developed-by: Jason A. Donenfeld Signed-off-by: Pa