Re: [PATCH v2 0/2] Define NPCM7XX PWRON bit fields

2022-04-21 Thread Peter Maydell 
On Mon, 11 Apr 2022 at 17:58, Hao Wu  wrote:
>
> Currently, the PWRON STRAP values in NPCM7XX boards are magic
> numbers. Similar to the aspeed ones in hw/arm/aspeed.c, we
> define bit fields constants for them and use these fields instead
> of the magic numbers in the current implementation. The code
> should behave exactly the same as the existing one.
>
> -- Changes since v1
> * Fix errors and apply suggestions Peter made on v1.



Applied to target-arm.next, thanks.

-- PMM

[PATCH v2 0/2] Define NPCM7XX PWRON bit fields

2022-04-11 Thread Hao Wu 
Currently, the PWRON STRAP values in NPCM7XX boards are magic
numbers. Similar to the aspeed ones in hw/arm/aspeed.c, we
define bit fields constants for them and use these fields instead
of the magic numbers in the current implementation. The code
should behave exactly the same as the existing one.

-- Changes since v1
* Fix errors and apply suggestions Peter made on v1.

Hao Wu (2):
  hw/misc: Add PWRON STRAP bit fields in GCR module
  hw/arm: Use bit fields for NPCM7XX PWRON STRAPs

 hw/arm/npcm7xx_boards.c   | 24 +++-
 include/hw/misc/npcm7xx_gcr.h | 30 ++
 2 files changed, 49 insertions(+), 5 deletions(-)

-- 
2.35.1.1178.g4f1659d476-goog