Re: [PATCH v2 07/12] qapi/schema: make QAPISourceInfo mandatory

2021-01-13 Thread John Snow
On 1/13/21 7:29 PM, Eduardo Habkost wrote: On Wed, Jan 13, 2021 at 06:04:29PM -0500, John Snow wrote: On 1/13/21 11:12 AM, Markus Armbruster wrote: John Snow writes: ... I think we need to, yes; or we probably really, really want to. Making the info parameter optional really adds a lot

Re: [PATCH v2 07/12] qapi/schema: make QAPISourceInfo mandatory

2021-01-13 Thread Eduardo Habkost
On Wed, Jan 13, 2021 at 06:04:29PM -0500, John Snow wrote: > On 1/13/21 11:12 AM, Markus Armbruster wrote: > > John Snow writes: > > > > > Signed-off-by: John Snow > > > > > > --- > > > > > > The event_enum_members change might become irrelevant after a > > > forthcoming (?) patch by Markus,

Re: [PATCH v2 07/12] qapi/schema: make QAPISourceInfo mandatory

2021-01-13 Thread John Snow
On 1/13/21 11:12 AM, Markus Armbruster wrote: John Snow writes: Signed-off-by: John Snow --- The event_enum_members change might become irrelevant after a forthcoming (?) patch by Markus, but didn't have it in-hand at time of publishing. It's in my "[PATCH 00/11] Drop support for QAPIGen

Re: [PATCH v2 07/12] qapi/schema: make QAPISourceInfo mandatory

2021-01-13 Thread Markus Armbruster
John Snow writes: > Signed-off-by: John Snow > > --- > > The event_enum_members change might become irrelevant after a > forthcoming (?) patch by Markus, but didn't have it in-hand at time of > publishing. It's in my "[PATCH 00/11] Drop support for QAPIGen without a file name", which includes

[PATCH v2 07/12] qapi/schema: make QAPISourceInfo mandatory

2020-12-16 Thread John Snow
Signed-off-by: John Snow --- The event_enum_members change might become irrelevant after a forthcoming (?) patch by Markus, but didn't have it in-hand at time of publishing. Signed-off-by: John Snow --- scripts/qapi/events.py | 2 +- scripts/qapi/schema.py | 25 ++---