Re: [PATCH v2 07/22] target/loongarch: Add fixed point arithmetic instruction translation

2021-07-26 Thread Song Gao
Hi, Richard. On 07/26/2021 11:53 PM, Richard Henderson wrote: > On 7/26/21 1:56 AM, Song Gao wrote: >> Hi, Richard. >> >> On 07/23/2021 08:46 AM, Richard Henderson wrote: >>> On 7/20/21 11:53 PM, Song Gao wrote: +/* Fixed point arithmetic operation instruction translation */ +static

Re: [PATCH v2 07/22] target/loongarch: Add fixed point arithmetic instruction translation

2021-07-26 Thread Richard Henderson
On 7/26/21 1:56 AM, Song Gao wrote: Hi, Richard. On 07/23/2021 08:46 AM, Richard Henderson wrote: On 7/20/21 11:53 PM, Song Gao wrote: +/* Fixed point arithmetic operation instruction translation */ +static bool trans_add_w(DisasContext *ctx, arg_add_w *a) +{ +    TCGv Rd = cpu_gpr[a->rd]; +  

Re: [PATCH v2 07/22] target/loongarch: Add fixed point arithmetic instruction translation

2021-07-26 Thread Song Gao
Hi, Richard. On 07/23/2021 08:46 AM, Richard Henderson wrote: > On 7/20/21 11:53 PM, Song Gao wrote: >> +/* Fixed point arithmetic operation instruction translation */ >> +static bool trans_add_w(DisasContext *ctx, arg_add_w *a) >> +{ >> +    TCGv Rd = cpu_gpr[a->rd]; >> +    TCGv Rj =

Re: [PATCH v2 07/22] target/loongarch: Add fixed point arithmetic instruction translation

2021-07-22 Thread Richard Henderson
On 7/20/21 11:53 PM, Song Gao wrote: +/* Fixed point arithmetic operation instruction translation */ +static bool trans_add_w(DisasContext *ctx, arg_add_w *a) +{ +TCGv Rd = cpu_gpr[a->rd]; +TCGv Rj = cpu_gpr[a->rj]; +TCGv Rk = cpu_gpr[a->rk]; + +if (a->rd == 0) { +/* Nop

Re: [PATCH v2 07/22] target/loongarch: Add fixed point arithmetic instruction translation

2021-07-22 Thread Song Gao
Hi, Philippe, On 07/22/2021 01:49 AM, Philippe Mathieu-Daudé wrote: > On 7/21/21 7:38 PM, Philippe Mathieu-Daudé wrote: >> On 7/21/21 11:53 AM, Song Gao wrote: >>> This patch implement fixed point arithemtic instruction translation. > > Typo arithmetic. > >>> >>> This includes: >>> - ADD.{W/D},

Re: [PATCH v2 07/22] target/loongarch: Add fixed point arithmetic instruction translation

2021-07-21 Thread Philippe Mathieu-Daudé
On 7/21/21 7:38 PM, Philippe Mathieu-Daudé wrote: > On 7/21/21 11:53 AM, Song Gao wrote: >> This patch implement fixed point arithemtic instruction translation. Typo arithmetic. >> >> This includes: >> - ADD.{W/D}, SUB.{W/D} >> - ADDI.{W/D}, ADDU16ID >> - ALSL.{W[U]/D} >> - LU12I.W, LU32I.D

Re: [PATCH v2 07/22] target/loongarch: Add fixed point arithmetic instruction translation

2021-07-21 Thread Philippe Mathieu-Daudé
On 7/21/21 11:53 AM, Song Gao wrote: > This patch implement fixed point arithemtic instruction translation. > > This includes: > - ADD.{W/D}, SUB.{W/D} > - ADDI.{W/D}, ADDU16ID > - ALSL.{W[U]/D} > - LU12I.W, LU32I.D LU52I.D > - SLT[U], SLT[U]I > - PCADDI, PCADDU12I, PCADDU18I, PCALAU12I > - AND,

[PATCH v2 07/22] target/loongarch: Add fixed point arithmetic instruction translation

2021-07-21 Thread Song Gao
This patch implement fixed point arithemtic instruction translation. This includes: - ADD.{W/D}, SUB.{W/D} - ADDI.{W/D}, ADDU16ID - ALSL.{W[U]/D} - LU12I.W, LU32I.D LU52I.D - SLT[U], SLT[U]I - PCADDI, PCADDU12I, PCADDU18I, PCALAU12I - AND, OR, NOR, XOR, ANDN, ORN - MUL.{W/D}, MULH.{W[U]/D[U]} -