Re: [PATCH v2 1/2] hw/riscv: Add fw_cfg support to virt

Hi Asherah, On Sun, Feb 28, 2021 at 7:18 PM Asherah Connor wrote: > > Hi Bin, > > Thanks very much for your review. > > On 21/02/28 02:02:p, Bin Meng wrote: > > I guess this is put here because riscv_load_fdt() is trying to touch > > the device tree, and creating fw_cfg has to be done before

Re: [PATCH v2 1/2] hw/riscv: Add fw_cfg support to virt

Hi Bin, Thanks very much for your review. On 21/02/28 02:02:p, Bin Meng wrote: > I guess this is put here because riscv_load_fdt() is trying to touch > the device tree, and creating fw_cfg has to be done before that? > Maybe a comment is needed to prevent whoever later wanted to move the > codes

Re: [PATCH v2 1/2] hw/riscv: Add fw_cfg support to virt

On Fri, Feb 26, 2021 at 12:31 PM Asherah Connor wrote: > > Provides fw_cfg for the virt machine on riscv. This enables > using e.g. ramfb later. > > Signed-off-by: Asherah Connor > --- > > Changes in v2: > * Add DMA support (needed for writes). > > hw/riscv/Kconfig| 1 + >

[PATCH v2 1/2] hw/riscv: Add fw_cfg support to virt

Provides fw_cfg for the virt machine on riscv. This enables using e.g. ramfb later. Signed-off-by: Asherah Connor --- Changes in v2: * Add DMA support (needed for writes). hw/riscv/Kconfig| 1 + hw/riscv/virt.c | 27 +++ include/hw/riscv/virt.h | 4