Re: [PATCH v2 1/3] macio: don't reference serial_hd() directly within the device

2020-10-17 Thread David Gibson
On Fri, Oct 16, 2020 at 08:00:06AM +0100, Mark Cave-Ayland wrote: > On 16/10/2020 01:16, David Gibson wrote: > > > On Tue, Oct 13, 2020 at 12:49:20PM +0100, Mark Cave-Ayland wrote: > > > Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at > > > the > > > Mac Old World and

Re: [PATCH v2 1/3] macio: don't reference serial_hd() directly within the device

2020-10-16 Thread Mark Cave-Ayland
On 16/10/2020 01:16, David Gibson wrote: On Tue, Oct 13, 2020 at 12:49:20PM +0100, Mark Cave-Ayland wrote: Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the Mac Old World and New World machine level. Also remove the now obsolete comment referring to the use of

Re: [PATCH v2 1/3] macio: don't reference serial_hd() directly within the device

2020-10-15 Thread David Gibson
On Tue, Oct 13, 2020 at 12:49:20PM +0100, Mark Cave-Ayland wrote: > Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the > Mac Old World and New World machine level. > > Also remove the now obsolete comment referring to the use of serial_hd() and > the setting of

[PATCH v2 1/3] macio: don't reference serial_hd() directly within the device

2020-10-13 Thread Mark Cave-Ayland
Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the Mac Old World and New World machine level. Also remove the now obsolete comment referring to the use of serial_hd() and the setting of user_creatable to false accordingly. Signed-off-by: Mark Cave-Ayland ---