Re: [PATCH v2 1/7] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features

2020-08-19 Thread Igor Mammedov
On Wed, 19 Aug 2020 11:14:45 +0200 Laszlo Ersek wrote: > On 08/19/20 10:58, Cornelia Huck wrote: > > > I consider any patch that adds compat options without adding all compat > > machines first to be buggy. We had that in the past, and it had been > > painful to sort it out again later. That's

Re: [PATCH v2 1/7] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features

2020-08-19 Thread Laszlo Ersek
On 08/19/20 10:58, Cornelia Huck wrote: > I consider any patch that adds compat options without adding all compat > machines first to be buggy. We had that in the past, and it had been > painful to sort it out again later. That's why I usually post a compat > machines patch during hardfreeze, to

Re: [PATCH v2 1/7] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features

2020-08-19 Thread Cornelia Huck
On Wed, 19 Aug 2020 10:39:04 +0200 Laszlo Ersek wrote: > Hi Igor, > > (CC'ing Daniel, Cornelia, David, Peter) > > On 08/18/20 14:22, Igor Mammedov wrote: > > It will allow firmware to notify QEMU that firmware requires SMI > > being triggered on CPU hot[un]plug, so that it would be able to

Re: [PATCH v2 1/7] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features

2020-08-19 Thread Laszlo Ersek
correcting myself a bit, with Drew and Thomas CC'd as well: On 08/19/20 10:39, Laszlo Ersek wrote: > Hi Igor, > > (CC'ing Daniel, Cornelia, David, Peter) > > On 08/18/20 14:22, Igor Mammedov wrote: >> It will allow firmware to notify QEMU that firmware requires SMI >> being triggered on CPU

Re: [PATCH v2 1/7] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features

2020-08-19 Thread Laszlo Ersek
Hi Igor, (CC'ing Daniel, Cornelia, David, Peter) On 08/18/20 14:22, Igor Mammedov wrote: > It will allow firmware to notify QEMU that firmware requires SMI > being triggered on CPU hot[un]plug, so that it would be able to account > for hotplugged CPU and relocate it to new SMM base and/or safely

[PATCH v2 1/7] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features

2020-08-18 Thread Igor Mammedov
It will allow firmware to notify QEMU that firmware requires SMI being triggered on CPU hot[un]plug, so that it would be able to account for hotplugged CPU and relocate it to new SMM base and/or safely remove CPU on unplug. Using negotiated features, follow up patches will insert SMI upcall into