Re: [PATCH v2 1/8] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-03-18 Thread Philippe Mathieu-Daudé
Hi Eduardo, On 3/16/20 1:03 AM, Philippe Mathieu-Daudé wrote: Move out x86-specific structures from generic machine code. If you have to respin "x86 and machine queue" please consider including this patch :) Acked-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH v2 1/8] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-03-16 Thread Philippe Mathieu-Daudé
On 3/16/20 1:29 AM, Aleksandar Markovic wrote: On Monday, March 16, 2020, Philippe Mathieu-Daudé > wrote: Move out x86-specific structures from generic machine code. Philippe, I a kind of have hard time understanding what is achieved with this patch. Is this

Re: [PATCH v2 1/8] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-03-15 Thread Aleksandar Markovic
On Monday, March 16, 2020, Aleksandar Markovic wrote: > > > On Monday, March 16, 2020, Philippe Mathieu-Daudé > wrote: > >> Move out x86-specific structures from generic machine code. >> >> > Philippe, > > I a kind of have hard time understanding what is achieved with this patch. > Is this pure

Re: [PATCH v2 1/8] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-03-15 Thread Aleksandar Markovic
On Monday, March 16, 2020, Philippe Mathieu-Daudé wrote: > Move out x86-specific structures from generic machine code. > > Philippe, I a kind of have hard time understanding what is achieved with this patch. Is this pure code moving/reorganization? What is the logical connection between this

[PATCH v2 1/8] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-03-15 Thread Philippe Mathieu-Daudé
Move out x86-specific structures from generic machine code. Acked-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- qapi/machine-target.json | 45 ++ qapi/machine.json | 42 --- target/i386/cpu.c