Re: [PATCH v2 2/4] virtio_net: copy VIRTIO_NET_S_ANNOUNCE if device model has it
On Wed, Nov 30, 2022 at 7:58 AM Jason Wang wrote: > > On Fri, Nov 25, 2022 at 1:33 AM Eugenio Pérez wrote: > > > > Status part of the emulated feature. It will follow device model, so we > > must copy it as long as NIC device model has it set. > > > > Signed-off-by: Eugenio Pérez > > --- > > hw/net/virtio-net.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > > index eed629766f..bf71ef33e8 100644 > > --- a/hw/net/virtio-net.c > > +++ b/hw/net/virtio-net.c > > @@ -183,6 +183,7 @@ static void virtio_net_get_config(VirtIODevice *vdev, > > uint8_t *config) > > memcpy(netcfg.mac, n->mac, ETH_ALEN); > > } > > > > +netcfg.status |= (n->status & VIRTIO_NET_S_ANNOUNCE); > > Do we need to care about the endian here? We use: > > virtio_stw_p(vdev, , n->status); > > At the beginning of this function. > Right, this is a miss. I'll fix it in the next version. Thanks!
Re: [PATCH v2 2/4] virtio_net: copy VIRTIO_NET_S_ANNOUNCE if device model has it
On Wed, Nov 30, 2022 at 02:58:35PM +0800, Jason Wang wrote: > On Fri, Nov 25, 2022 at 1:33 AM Eugenio Pérez wrote: > > > > Status part of the emulated feature. It will follow device model, so we > > must copy it as long as NIC device model has it set. > > > > Signed-off-by: Eugenio Pérez > > --- > > hw/net/virtio-net.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > > index eed629766f..bf71ef33e8 100644 > > --- a/hw/net/virtio-net.c > > +++ b/hw/net/virtio-net.c > > @@ -183,6 +183,7 @@ static void virtio_net_get_config(VirtIODevice *vdev, > > uint8_t *config) > > memcpy(netcfg.mac, n->mac, ETH_ALEN); > > } > > > > +netcfg.status |= (n->status & VIRTIO_NET_S_ANNOUNCE); > > Do we need to care about the endian here? We use: > > virtio_stw_p(vdev, , n->status); > > At the beginning of this function. > > Thanks Didn't see this answered. > > memcpy(config, , n->config_size); > > } > > } > > -- > > 2.31.1 > >
Re: [PATCH v2 2/4] virtio_net: copy VIRTIO_NET_S_ANNOUNCE if device model has it
On Fri, Nov 25, 2022 at 1:33 AM Eugenio Pérez wrote: > > Status part of the emulated feature. It will follow device model, so we > must copy it as long as NIC device model has it set. > > Signed-off-by: Eugenio Pérez > --- > hw/net/virtio-net.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > index eed629766f..bf71ef33e8 100644 > --- a/hw/net/virtio-net.c > +++ b/hw/net/virtio-net.c > @@ -183,6 +183,7 @@ static void virtio_net_get_config(VirtIODevice *vdev, > uint8_t *config) > memcpy(netcfg.mac, n->mac, ETH_ALEN); > } > > +netcfg.status |= (n->status & VIRTIO_NET_S_ANNOUNCE); Do we need to care about the endian here? We use: virtio_stw_p(vdev, , n->status); At the beginning of this function. Thanks > memcpy(config, , n->config_size); > } > } > -- > 2.31.1 >
[PATCH v2 2/4] virtio_net: copy VIRTIO_NET_S_ANNOUNCE if device model has it
Status part of the emulated feature. It will follow device model, so we must copy it as long as NIC device model has it set. Signed-off-by: Eugenio Pérez --- hw/net/virtio-net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index eed629766f..bf71ef33e8 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -183,6 +183,7 @@ static void virtio_net_get_config(VirtIODevice *vdev, uint8_t *config) memcpy(netcfg.mac, n->mac, ETH_ALEN); } +netcfg.status |= (n->status & VIRTIO_NET_S_ANNOUNCE); memcpy(config, , n->config_size); } } -- 2.31.1
