Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-27 Thread Markus Armbruster
Claudio Fontana writes: > On 11/27/20 3:45 PM, Markus Armbruster wrote: >> Claudio Fontana writes: >> >>> On 11/26/20 10:48 PM, Eduardo Habkost wrote: On Thu, Nov 26, 2020 at 10:06:03PM +0100, Claudio Fontana wrote: > On 11/26/20 3:25 PM, Paolo Bonzini wrote: >> On 26/11/20 15:13,

Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-27 Thread Claudio Fontana
On 11/27/20 3:45 PM, Markus Armbruster wrote: > Claudio Fontana writes: > >> On 11/26/20 10:48 PM, Eduardo Habkost wrote: >>> On Thu, Nov 26, 2020 at 10:06:03PM +0100, Claudio Fontana wrote: On 11/26/20 3:25 PM, Paolo Bonzini wrote: > On 26/11/20 15:13, Claudio Fontana wrote: >> One

Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-27 Thread Markus Armbruster
Claudio Fontana writes: > On 11/26/20 10:48 PM, Eduardo Habkost wrote: >> On Thu, Nov 26, 2020 at 10:06:03PM +0100, Claudio Fontana wrote: >>> On 11/26/20 3:25 PM, Paolo Bonzini wrote: On 26/11/20 15:13, Claudio Fontana wrote: > One option I see is simply to document the behavior where

Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-27 Thread Cornelia Huck
On Wed, 25 Nov 2020 15:56:32 -0500 Eduardo Habkost wrote: > This function will be used to replace the xen_available() and > kvm_available() functions from arch_init.c. > > Signed-off-by: Eduardo Habkost > --- > Cc: Richard Henderson > Cc: Paolo Bonzini > Cc: Claudio Fontana > Cc: Roman

Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-27 Thread Claudio Fontana
On 11/26/20 10:48 PM, Eduardo Habkost wrote: > On Thu, Nov 26, 2020 at 10:06:03PM +0100, Claudio Fontana wrote: >> On 11/26/20 3:25 PM, Paolo Bonzini wrote: >>> On 26/11/20 15:13, Claudio Fontana wrote: One option I see is simply to document the behavior where accel_available() is

Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-26 Thread Paolo Bonzini
On 26/11/20 22:06, Claudio Fontana wrote: I think it's just that the usecase is not that common. "Is this accelerator compiled in the binary" is not something you need after startup (or if querying the monitor). A script that repeatedly uses the QMP interface to query for the status could

Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-26 Thread Eduardo Habkost
On Thu, Nov 26, 2020 at 10:06:03PM +0100, Claudio Fontana wrote: > On 11/26/20 3:25 PM, Paolo Bonzini wrote: > > On 26/11/20 15:13, Claudio Fontana wrote: > >> One option I see is simply to document the behavior where > >> accel_available() is declared in accel.h (ie do not use in fast > >> path),

Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-26 Thread Claudio Fontana
On 11/26/20 3:25 PM, Paolo Bonzini wrote: > On 26/11/20 15:13, Claudio Fontana wrote: >> One option I see is simply to document the behavior where >> accel_available() is declared in accel.h (ie do not use in fast >> path), as well as in accel_find() actually, so that both accel_find() >> and

Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-26 Thread Paolo Bonzini
On 26/11/20 15:13, Claudio Fontana wrote: One option I see is simply to document the behavior where accel_available() is declared in accel.h (ie do not use in fast path), as well as in accel_find() actually, so that both accel_find() and accel_available() are avoided in fast path and avoid being

Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-26 Thread Claudio Fontana
On 11/26/20 2:36 PM, Eduardo Habkost wrote: > On Thu, Nov 26, 2020 at 10:14:31AM +0100, Claudio Fontana wrote: >> Hi Eduardo, >> >> On 11/25/20 9:56 PM, Eduardo Habkost wrote: >>> This function will be used to replace the xen_available() and >>> kvm_available() functions from arch_init.c. >>> >>>

Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-26 Thread Eduardo Habkost
On Thu, Nov 26, 2020 at 10:14:31AM +0100, Claudio Fontana wrote: > Hi Eduardo, > > On 11/25/20 9:56 PM, Eduardo Habkost wrote: > > This function will be used to replace the xen_available() and > > kvm_available() functions from arch_init.c. > > > > Signed-off-by: Eduardo Habkost > > --- > > Cc:

Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-26 Thread Claudio Fontana
Hi Eduardo, On 11/25/20 9:56 PM, Eduardo Habkost wrote: > This function will be used to replace the xen_available() and > kvm_available() functions from arch_init.c. > > Signed-off-by: Eduardo Habkost > --- > Cc: Richard Henderson > Cc: Paolo Bonzini > Cc: Claudio Fontana > Cc: Roman

[PATCH v2 2/6] accel: accel_available() function

2020-11-25 Thread Eduardo Habkost
This function will be used to replace the xen_available() and kvm_available() functions from arch_init.c. Signed-off-by: Eduardo Habkost --- Cc: Richard Henderson Cc: Paolo Bonzini Cc: Claudio Fontana Cc: Roman Bolshakov --- include/sysemu/accel.h | 1 + accel/accel.c | 5 + 2