Re: [PATCH v2 20/20] tests: acpi: update expected SSDT.dimmpxm blob
On Wed, 6 Mar 2024 14:50:20 +0530 Ani Sinha wrote: > > On 05-Mar-2024, at 21:27, Igor Mammedov wrote: > > > > address shift is caused by switch to 32-bit SMBIOS entry point > > which has slightly different size from 64-bit one and happens > > to trigger a bit different memory layout. > > Why does it affect only q35 machines and not i440fx as well? that what tests show, mem layout is a bit different between those > > > > > Expected diff: > > > > -Name (MEMA, 0x07FFE000) > > +Name (MEMA, 0x07FFF000) > > > > Signed-off-by: Igor Mammedov > > Acked-by: Ani Sinha > > > --- > > tests/qtest/bios-tables-test-allowed-diff.h | 1 - > > tests/data/acpi/q35/SSDT.dimmpxm| Bin 1815 -> 1815 bytes > > 2 files changed, 1 deletion(-) > > > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h > > b/tests/qtest/bios-tables-test-allowed-diff.h > > index 81148a604f..dfb8523c8b 100644 > > --- a/tests/qtest/bios-tables-test-allowed-diff.h > > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > > @@ -1,2 +1 @@ > > /* List of comma-separated changed AML files to ignore */ > > -"tests/data/acpi/q35/SSDT.dimmpxm", > > diff --git a/tests/data/acpi/q35/SSDT.dimmpxm > > b/tests/data/acpi/q35/SSDT.dimmpxm > > index > > 70f133412f5e0aa128ab210245a8de7304eeb843..9ea4e0d0ceaa8a5cbd706afb6d49de853fafe654 > > 100644 > > GIT binary patch > > delta 23 > > ecmbQvH=U0wIM^jboSlJzam_|9E_UV*|JeaVTLvQl > > > > delta 23 > > ecmbQvH=U0wIM^jboSlJzanD9BE_UVz|JeaVy9Ofw > > > > -- > > 2.39.3 > > >
Re: [PATCH v2 20/20] tests: acpi: update expected SSDT.dimmpxm blob
> On 05-Mar-2024, at 21:27, Igor Mammedov wrote: > > address shift is caused by switch to 32-bit SMBIOS entry point > which has slightly different size from 64-bit one and happens > to trigger a bit different memory layout. Why does it affect only q35 machines and not i440fx as well? > > Expected diff: > > -Name (MEMA, 0x07FFE000) > +Name (MEMA, 0x07FFF000) > > Signed-off-by: Igor Mammedov Acked-by: Ani Sinha > --- > tests/qtest/bios-tables-test-allowed-diff.h | 1 - > tests/data/acpi/q35/SSDT.dimmpxm| Bin 1815 -> 1815 bytes > 2 files changed, 1 deletion(-) > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h > b/tests/qtest/bios-tables-test-allowed-diff.h > index 81148a604f..dfb8523c8b 100644 > --- a/tests/qtest/bios-tables-test-allowed-diff.h > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > @@ -1,2 +1 @@ > /* List of comma-separated changed AML files to ignore */ > -"tests/data/acpi/q35/SSDT.dimmpxm", > diff --git a/tests/data/acpi/q35/SSDT.dimmpxm > b/tests/data/acpi/q35/SSDT.dimmpxm > index > 70f133412f5e0aa128ab210245a8de7304eeb843..9ea4e0d0ceaa8a5cbd706afb6d49de853fafe654 > 100644 > GIT binary patch > delta 23 > ecmbQvH=U0wIM^jboSlJzam_|9E_UV*|JeaVTLvQl > > delta 23 > ecmbQvH=U0wIM^jboSlJzanD9BE_UVz|JeaVy9Ofw > > -- > 2.39.3 >
[PATCH v2 20/20] tests: acpi: update expected SSDT.dimmpxm blob
address shift is caused by switch to 32-bit SMBIOS entry point which has slightly different size from 64-bit one and happens to trigger a bit different memory layout. Expected diff: -Name (MEMA, 0x07FFE000) +Name (MEMA, 0x07FFF000) Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 1 - tests/data/acpi/q35/SSDT.dimmpxm| Bin 1815 -> 1815 bytes 2 files changed, 1 deletion(-) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index 81148a604f..dfb8523c8b 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1,2 +1 @@ /* List of comma-separated changed AML files to ignore */ -"tests/data/acpi/q35/SSDT.dimmpxm", diff --git a/tests/data/acpi/q35/SSDT.dimmpxm b/tests/data/acpi/q35/SSDT.dimmpxm index 70f133412f5e0aa128ab210245a8de7304eeb843..9ea4e0d0ceaa8a5cbd706afb6d49de853fafe654 100644 GIT binary patch delta 23 ecmbQvH=U0wIM^jboSlJzam_|9E_UV*|JeaVTLvQl delta 23 ecmbQvH=U0wIM^jboSlJzanD9BE_UVz|JeaVy9Ofw -- 2.39.3
