Re: [PATCH v2 22/29] target/arm: Improve vector REV

[Philippe Mathieu-Daudé]

On 6/22/21 1:18 AM, Richard Henderson wrote:
> We can eliminate the requirement for a zero-extended output,
> because the following store will ignore any garbage high bits.
> 
> Reviewed-by: Peter Maydell 
> Signed-off-by: Richard Henderson 
> ---
>  target/arm/translate-a64.c | 6 ++
>  1 file changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé 

[PATCH v2 22/29] target/arm: Improve vector REV

[Richard Henderson]

We can eliminate the requirement for a zero-extended output,
because the following store will ignore any garbage high bits.

Reviewed-by: Peter Maydell 
Signed-off-by: Richard Henderson 
---
 target/arm/translate-a64.c | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 304fd3d370..1a40e49db7 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -12444,12 +12444,10 @@ static void handle_rev(DisasContext *s, int opcode, 
bool u,
 read_vec_element(s, tcg_tmp, rn, i, grp_size);
 switch (grp_size) {
 case MO_16:
-tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp,
-TCG_BSWAP_IZ | TCG_BSWAP_OZ);
+tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp, TCG_BSWAP_IZ);
 break;
 case MO_32:
-tcg_gen_bswap32_i64(tcg_tmp, tcg_tmp,
-TCG_BSWAP_IZ | TCG_BSWAP_OZ);
+tcg_gen_bswap32_i64(tcg_tmp, tcg_tmp, TCG_BSWAP_IZ);
 break;
 case MO_64:
 tcg_gen_bswap64_i64(tcg_tmp, tcg_tmp);
-- 
2.25.1