Re: [PATCH v2 24/37] target/i386: reimplement 0x0f 0xd0-0xd7, 0xe0-0xe7, 0xf0-0xf7, add AVX

2022-09-26 Thread Paolo Bonzini
On Sat, Sep 24, 2022 at 10:56 PM Richard Henderson wrote: > > On 9/20/22 17:24, Paolo Bonzini wrote: > > For LDDQU, using gen_load_sse directly might corrupt the register if > > the second part of the load fails. > > Surely LDDQU is not unique in this? I would think ldo/ldy both need fixing >

Re: [PATCH v2 24/37] target/i386: reimplement 0x0f 0xd0-0xd7, 0xe0-0xe7, 0xf0-0xf7, add AVX

2022-09-24 Thread Richard Henderson
On 9/20/22 17:24, Paolo Bonzini wrote: For LDDQU, using gen_load_sse directly might corrupt the register if the second part of the load fails. Surely LDDQU is not unique in this? I would think ldo/ldy both need fixing to load to temps first. Anyway, this patch is Reviewed-by: Richard

[PATCH v2 24/37] target/i386: reimplement 0x0f 0xd0-0xd7, 0xe0-0xe7, 0xf0-0xf7, add AVX

2022-09-20 Thread Paolo Bonzini
The more complicated ones here are d6-d7, e6-e7, f7. The others are trivial. For LDDQU, using gen_load_sse directly might corrupt the register if the second part of the load fails. Therefore, add a custom X86_TYPE_WM value; like X86_TYPE_W it does call gen_load(), but it also rejects a value of