ev.ng;
> Marco Liebel (QUIC) ; ltaylorsimp...@gmail.com;
> Thomas Huth ; Daniel P. Berrangé
> ; qemu-devel@nongnu.org
> Subject: Re: [PATCH v2 3/3] target/hexagon: avoid shadowing globals
>
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any link
On 10/10/2023 09.34, Philippe Mathieu-Daudé wrote:
On 10/10/23 08:04, Markus Armbruster wrote:
Philippe Mathieu-Daudé writes:
[...]
If we have to clean that for -Wshadow=global, I'm tempted to rename
the typedef as 'vaddr_t' and keep the 'vaddr' variable names.
POSIX reserves suffix _t,
On 10/10/23 08:04, Markus Armbruster wrote:
Philippe Mathieu-Daudé writes:
[...]
If we have to clean that for -Wshadow=global, I'm tempted to rename
the typedef as 'vaddr_t' and keep the 'vaddr' variable names.
POSIX reserves suffix _t, see
Philippe Mathieu-Daudé writes:
[...]
> If we have to clean that for -Wshadow=global, I'm tempted to rename
> the typedef as 'vaddr_t' and keep the 'vaddr' variable names.
POSIX reserves suffix _t, see
https://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_02_02
Do we
On 9/10/23 22:53, Brian Cain wrote:
On 9/10/23 08:09, Philippe Mathieu-Daudé wrote:
On 6/10/23 00:22, Brian Cain wrote:
The typedef `vaddr` is shadowed by `vaddr` identifiers, so we rename the
identifiers to avoid shadowing the type name.
This one surprises me, since we have other
Philippe Mathieu-Daudé writes:
> On 9/10/23 08:09, Philippe Mathieu-Daudé wrote:
>> Hi Brian,
>> On 6/10/23 00:22, Brian Cain wrote:
>>> The typedef `vaddr` is shadowed by `vaddr` identifiers, so we rename the
>>> identifiers to avoid shadowing the type name.
>> This one surprises me, since we
dhat.com; a...@rev.ng;
> a...@rev.ng; Marco Liebel (QUIC) ;
> ltaylorsimp...@gmail.com; Thomas Huth ; Daniel P.
> Berrangé
> Subject: Re: [PATCH v2 3/3] target/hexagon: avoid shadowing globals
>
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any link
; stefa...@redhat.com; a...@rev.ng;
> a...@rev.ng; Marco Liebel (QUIC)
> Subject: RE: [PATCH v2 3/3] target/hexagon: avoid shadowing globals
>
>
>
> > -Original Message-
> > From: ltaylorsimp...@gmail.com
> > Sent: Friday, October 6, 2023 11:01 AM
On 9/10/23 08:09, Philippe Mathieu-Daudé wrote:
Hi Brian,
On 6/10/23 00:22, Brian Cain wrote:
The typedef `vaddr` is shadowed by `vaddr` identifiers, so we rename the
identifiers to avoid shadowing the type name.
This one surprises me, since we have other occurences:
Hi Brian,
On 6/10/23 00:22, Brian Cain wrote:
The typedef `vaddr` is shadowed by `vaddr` identifiers, so we rename the
identifiers to avoid shadowing the type name.
This one surprises me, since we have other occurences:
include/exec/memory.h:751:bool memory_get_xlat_addr(IOMMUTLBEntry
; stefa...@redhat.com; a...@rev.ng;
> a...@rev.ng; Marco Liebel (QUIC)
> Subject: RE: [PATCH v2 3/3] target/hexagon: avoid shadowing globals
>
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any links or attachments, and do not enable macros.
>
; stefa...@redhat.com; a...@rev.ng; a...@rev.ng;
> quic_mlie...@quicinc.com; ltaylorsimp...@gmail.com
> Subject: [PATCH v2 3/3] target/hexagon: avoid shadowing globals
>
> The typedef `vaddr` is shadowed by `vaddr` identifiers, so we rename the
> identifiers to avoid shadowing the
The typedef `vaddr` is shadowed by `vaddr` identifiers, so we rename the
identifiers to avoid shadowing the type name.
The global `cpu_env` is shadowed by local `cpu_env` arguments, so we
rename the function arguments to avoid shadowing the global.
Signed-off-by: Brian Cain
---
13 matches
Mail list logo
