Re: [PATCH v2 3/3] trace: Example of "centralized" recorder tracing

2020-07-03 Thread Christophe de Dinechin
On 2020-07-03 at 15:08 CEST, Daniel P. Berrangé wrote... > On Fri, Jul 03, 2020 at 12:12:14PM +0200, Christophe de Dinechin wrote: >> >> On 2020-07-02 at 15:47 CEST, Stefan Hajnoczi wrote... >> > On Wed, Jul 01, 2020 at 05:15:01PM +0100, Daniel P. Berrangé wrote: >> > At most it should require

Re: [PATCH v2 3/3] trace: Example of "centralized" recorder tracing

2020-07-03 Thread Daniel P . Berrangé
On Fri, Jul 03, 2020 at 12:12:14PM +0200, Christophe de Dinechin wrote: > > On 2020-07-02 at 15:47 CEST, Stefan Hajnoczi wrote... > > On Wed, Jul 01, 2020 at 05:15:01PM +0100, Daniel P. Berrangé wrote: > > At most it should require an > >> extra annotation in the trace-events file to take the

Re: [PATCH v2 3/3] trace: Example of "centralized" recorder tracing

2020-07-03 Thread Christophe de Dinechin
On 2020-07-02 at 15:47 CEST, Stefan Hajnoczi wrote... > On Wed, Jul 01, 2020 at 05:15:01PM +0100, Daniel P. Berrangé wrote: >> On Wed, Jul 01, 2020 at 05:09:06PM +0100, Stefan Hajnoczi wrote: >> > On Tue, Jun 30, 2020 at 01:41:36PM +0100, Daniel P. Berrangé wrote: >> > > On Fri, Jun 26, 2020 at

Re: [PATCH v2 3/3] trace: Example of "centralized" recorder tracing

2020-07-02 Thread Stefan Hajnoczi
On Wed, Jul 01, 2020 at 05:15:01PM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 01, 2020 at 05:09:06PM +0100, Stefan Hajnoczi wrote: > > On Tue, Jun 30, 2020 at 01:41:36PM +0100, Daniel P. Berrangé wrote: > > > On Fri, Jun 26, 2020 at 06:27:06PM +0200, Christophe de Dinechin wrote: > > > IMHO

Re: [PATCH v2 3/3] trace: Example of "centralized" recorder tracing

2020-07-01 Thread Daniel P . Berrangé
On Wed, Jul 01, 2020 at 05:09:06PM +0100, Stefan Hajnoczi wrote: > On Tue, Jun 30, 2020 at 01:41:36PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jun 26, 2020 at 06:27:06PM +0200, Christophe de Dinechin wrote: > > IMHO the whole point of having the pluggable trace backend impls, is > > precisely

Re: [PATCH v2 3/3] trace: Example of "centralized" recorder tracing

2020-07-01 Thread Stefan Hajnoczi
On Tue, Jun 30, 2020 at 01:41:36PM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 26, 2020 at 06:27:06PM +0200, Christophe de Dinechin wrote: > IMHO the whole point of having the pluggable trace backend impls, is > precisely that we don't have to add multiple different calls in the > code. A

Re: [PATCH v2 3/3] trace: Example of "centralized" recorder tracing

2020-06-30 Thread Stefan Hajnoczi
On Fri, Jun 26, 2020 at 06:27:06PM +0200, Christophe de Dinechin wrote: > This is an example showing how the recorder can be used to have one > "topic" covering multiple entries. Here, the topic is "lock". > > Here are a few use cases: > > - Checking locks: > RECORDER_TRACES=lock qemu > -

Re: [PATCH v2 3/3] trace: Example of "centralized" recorder tracing

2020-06-30 Thread Daniel P . Berrangé
On Fri, Jun 26, 2020 at 06:27:06PM +0200, Christophe de Dinechin wrote: > This is an example showing how the recorder can be used to have one > "topic" covering multiple entries. Here, the topic is "lock". > > Here are a few use cases: > > - Checking locks: > RECORDER_TRACES=lock qemu > -

[PATCH v2 3/3] trace: Example of "centralized" recorder tracing

2020-06-26 Thread Christophe de Dinechin
This is an example showing how the recorder can be used to have one "topic" covering multiple entries. Here, the topic is "lock". Here are a few use cases: - Checking locks: RECORDER_TRACES=lock qemu - Graphic visualization of locks: RECORDER_TRACES="lock=state,id" qemu &