Re: [PATCH v2 3/4] Hexagon (target/hexagon) cleanup gen_store_conditional[48] functions

2021-06-01 Thread Richard Henderson
On 6/1/21 4:19 PM, Taylor Simpson wrote: Previously the store-conditional code was writing to hex_pred[prednum]. Then, the fGEN_TCG override was reading from there to the destination variable so that the packet commit logic would handle it properly. The correct implementation is to write to the

[PATCH v2 3/4] Hexagon (target/hexagon) cleanup gen_store_conditional[48] functions

2021-06-01 Thread Taylor Simpson
Previously the store-conditional code was writing to hex_pred[prednum]. Then, the fGEN_TCG override was reading from there to the destination variable so that the packet commit logic would handle it properly. The correct implementation is to write to the destination variable and don't have the