Re: [PATCH v2 3/5] vhost-user-blk: add mechanism to track the guest notifiers init state

2020-05-06 Thread Dima Stepanov
On Sun, May 03, 2020 at 09:06:38PM -0400, Raphael Norwitz wrote: > Apologies for mixing up patches last time. This looks good from a > vhost-user-blk perspective, but I worry that some of these changes > could impact other vhost device types. > > I agree with adding notifiers_set to struct vhost_d

Re: [PATCH v2 3/5] vhost-user-blk: add mechanism to track the guest notifiers init state

2020-05-03 Thread Raphael Norwitz
Apologies for mixing up patches last time. This looks good from a vhost-user-blk perspective, but I worry that some of these changes could impact other vhost device types. I agree with adding notifiers_set to struct vhost_dev, and setting it in vhost_dev_enable/disable notifiers, but is there any

[PATCH v2 3/5] vhost-user-blk: add mechanism to track the guest notifiers init state

2020-04-30 Thread Dima Stepanov
In case of the vhost-user devices the daemon can be killed at any moment. Since QEMU supports the reconnet functionality the guest notifiers should be reset and disabled after "disconnect" event. The most issues were found if the "disconnect" event happened during vhost device initialization step.