Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-25 Thread Eduardo Habkost
On Wed, Nov 25, 2020 at 07:40:48AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Tue, Nov 24, 2020 at 04:20:37PM +0100, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > On Tue, Nov 24, 2020 at 09:49:30AM +0100, Markus Armbruster wrote: > >> >> Eduardo

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-24 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Nov 24, 2020 at 04:20:37PM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Tue, Nov 24, 2020 at 09:49:30AM +0100, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >> >> >> > On Mon, Nov 23, 2020 at 08:51:27AM +0100, Markus

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-24 Thread Eduardo Habkost
On Tue, Nov 24, 2020 at 04:20:37PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Tue, Nov 24, 2020 at 09:49:30AM +0100, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > On Mon, Nov 23, 2020 at 08:51:27AM +0100, Markus Armbruster wrote: > >> >> Eduardo

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-24 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Nov 24, 2020 at 09:49:30AM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Mon, Nov 23, 2020 at 08:51:27AM +0100, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >> >> >> > On Fri, Nov 20, 2020 at 06:29:16AM +0100, Markus

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-24 Thread Eduardo Habkost
On Tue, Nov 24, 2020 at 09:49:30AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, Nov 23, 2020 at 08:51:27AM +0100, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > On Fri, Nov 20, 2020 at 06:29:16AM +0100, Markus Armbruster wrote: > >> [...] > >> >>

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-24 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, Nov 23, 2020 at 08:51:27AM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Fri, Nov 20, 2020 at 06:29:16AM +0100, Markus Armbruster wrote: >> [...] >> >> When the structure of a data type is to be kept away from its users, I >> >> prefer

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-23 Thread Eduardo Habkost
On Mon, Nov 23, 2020 at 08:51:27AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Fri, Nov 20, 2020 at 06:29:16AM +0100, Markus Armbruster wrote: > [...] > >> When the structure of a data type is to be kept away from its users, I > >> prefer to keep it out of the public

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-22 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Nov 20, 2020 at 06:29:16AM +0100, Markus Armbruster wrote: [...] >> When the structure of a data type is to be kept away from its users, I >> prefer to keep it out of the public header, so the compiler enforces the >> encapsulation. > > I prefer that too, except

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-20 Thread Eduardo Habkost
On Fri, Nov 20, 2020 at 06:29:16AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Thu, Nov 19, 2020 at 11:24:52AM +0100, Markus Armbruster wrote: > >> Marc-André Lureau writes: > >> > >> > On Tue, Nov 17, 2020 at 6:42 PM Eduardo Habkost > >> > wrote: > >> > > >> >> On

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-20 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, Nov 19, 2020 at 01:21:58PM -0500, Eduardo Habkost wrote: >> On Thu, Nov 19, 2020 at 11:24:52AM +0100, Markus Armbruster wrote: > [...] >> > >> > > +return qnum_from_value((QNumValue) QNUM_VAL_INT(value)); >> > >> > No space between between (type) and its

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-19 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, Nov 19, 2020 at 11:24:52AM +0100, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >> > On Tue, Nov 17, 2020 at 6:42 PM Eduardo Habkost >> > wrote: >> > >> >> On Tue, Nov 17, 2020 at 12:37:56PM +0400, Marc-André Lureau wrote: >> >> > On Tue, Nov 17,

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-19 Thread Eduardo Habkost
On Thu, Nov 19, 2020 at 01:21:58PM -0500, Eduardo Habkost wrote: > On Thu, Nov 19, 2020 at 11:24:52AM +0100, Markus Armbruster wrote: [...] > > >> > > +return qnum_from_value((QNumValue) QNUM_VAL_INT(value)); > > > > No space between between (type) and its operand, please. > > > > Could we

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-19 Thread Eduardo Habkost
On Thu, Nov 19, 2020 at 11:24:52AM +0100, Markus Armbruster wrote: > Marc-André Lureau writes: > > > On Tue, Nov 17, 2020 at 6:42 PM Eduardo Habkost wrote: > > > >> On Tue, Nov 17, 2020 at 12:37:56PM +0400, Marc-André Lureau wrote: > >> > On Tue, Nov 17, 2020 at 2:43 AM Eduardo Habkost > >>

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-19 Thread Markus Armbruster
Marc-André Lureau writes: > On Tue, Nov 17, 2020 at 6:42 PM Eduardo Habkost wrote: > >> On Tue, Nov 17, 2020 at 12:37:56PM +0400, Marc-André Lureau wrote: >> > On Tue, Nov 17, 2020 at 2:43 AM Eduardo Habkost >> wrote: >> > >> > > Provide a separate QNumValue type that can be used for QNum

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-17 Thread Marc-André Lureau
On Tue, Nov 17, 2020 at 6:42 PM Eduardo Habkost wrote: > On Tue, Nov 17, 2020 at 12:37:56PM +0400, Marc-André Lureau wrote: > > On Tue, Nov 17, 2020 at 2:43 AM Eduardo Habkost > wrote: > > > > > Provide a separate QNumValue type that can be used for QNum value > > > literals without the

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-17 Thread Eduardo Habkost
On Tue, Nov 17, 2020 at 12:37:56PM +0400, Marc-André Lureau wrote: > On Tue, Nov 17, 2020 at 2:43 AM Eduardo Habkost wrote: > > > Provide a separate QNumValue type that can be used for QNum value > > literals without the referencing counting and memory allocation > > features provided by

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-17 Thread Marc-André Lureau
On Tue, Nov 17, 2020 at 2:43 AM Eduardo Habkost wrote: > Provide a separate QNumValue type that can be used for QNum value > literals without the referencing counting and memory allocation > features provided by QObject. > > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * Fix "make

[PATCH v2 3/8] qnum: QNumValue type for QNum value literals

2020-11-16 Thread Eduardo Habkost
Provide a separate QNumValue type that can be used for QNum value literals without the referencing counting and memory allocation features provided by QObject. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Fix "make check" failure, by updating check-qnum unit test to use the new