Re: [PATCH v2 4/8] ppc/spapr: Fix FWNMI machine check interrupt delivery

2020-03-16 Thread David Gibson
On Tue, Mar 17, 2020 at 09:19:57AM +1000, Nicholas Piggin wrote: > Cédric Le Goater's on March 17, 2020 3:59 am: > > On 3/16/20 3:26 PM, Nicholas Piggin wrote: > >> FWNMI machine check delivery misses a few things that will make it fail > >> with TCG at least (which we would like to allow in

Re: [PATCH v2 4/8] ppc/spapr: Fix FWNMI machine check interrupt delivery

2020-03-16 Thread Nicholas Piggin
Cédric Le Goater's on March 17, 2020 3:59 am: > On 3/16/20 3:26 PM, Nicholas Piggin wrote: >> FWNMI machine check delivery misses a few things that will make it fail >> with TCG at least (which we would like to allow in future to improve >> testing). > > I don't understand which issues are

Re: [PATCH v2 4/8] ppc/spapr: Fix FWNMI machine check interrupt delivery

2020-03-16 Thread Cédric Le Goater
On 3/16/20 3:26 PM, Nicholas Piggin wrote: > FWNMI machine check delivery misses a few things that will make it fail > with TCG at least (which we would like to allow in future to improve > testing). I don't understand which issues are addressed in the patch. > It's not nice to scatter interrupt

[PATCH v2 4/8] ppc/spapr: Fix FWNMI machine check interrupt delivery

2020-03-16 Thread Nicholas Piggin
FWNMI machine check delivery misses a few things that will make it fail with TCG at least (which we would like to allow in future to improve testing). It's not nice to scatter interrupt delivery logic around the tree, so move it to excp_helper.c and share code where possible. Signed-off-by: