Re: [PATCH v2 4/8] qnum: qnum_value_is_equal() function

2020-11-23 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Nov 20, 2020 at 07:52:31AM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Thu, Nov 19, 2020 at 11:27:40AM +0100, Markus Armbruster wrote: >> > [...] >> >> > +bool qnum_is_equal(const QObject *x, const QObject *y) >> >> > +{ >> >> > +

Re: [PATCH v2 4/8] qnum: qnum_value_is_equal() function

2020-11-20 Thread Eduardo Habkost
On Fri, Nov 20, 2020 at 07:52:31AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Thu, Nov 19, 2020 at 11:27:40AM +0100, Markus Armbruster wrote: > > [...] > >> > +bool qnum_is_equal(const QObject *x, const QObject *y) > >> > +{ > >> > +const QNum *qnum_x =

Re: [PATCH v2 4/8] qnum: qnum_value_is_equal() function

2020-11-19 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, Nov 19, 2020 at 11:27:40AM +0100, Markus Armbruster wrote: > [...] >> > +bool qnum_is_equal(const QObject *x, const QObject *y) >> > +{ >> > +const QNum *qnum_x = qobject_to(QNum, x); >> > +const QNum *qnum_y = qobject_to(QNum, y); >> >> Humor me: blank

Re: [PATCH v2 4/8] qnum: qnum_value_is_equal() function

2020-11-19 Thread Eduardo Habkost
On Thu, Nov 19, 2020 at 11:27:40AM +0100, Markus Armbruster wrote: [...] > > +bool qnum_is_equal(const QObject *x, const QObject *y) > > +{ > > +const QNum *qnum_x = qobject_to(QNum, x); > > +const QNum *qnum_y = qobject_to(QNum, y); > > Humor me: blank line between declarations and

Re: [PATCH v2 4/8] qnum: qnum_value_is_equal() function

2020-11-19 Thread Markus Armbruster
Eduardo Habkost writes: > Extract the QNum value comparison logic to a function that takes > QNumValue* as argument. > > Signed-off-by: Eduardo Habkost > --- > include/qapi/qmp/qnum.h | 1 + > qobject/qnum.c | 29 +++-- > 2 files changed, 20 insertions(+), 10

Re: [PATCH v2 4/8] qnum: qnum_value_is_equal() function

2020-11-17 Thread Eduardo Habkost
On Tue, Nov 17, 2020 at 08:53:19PM +0400, Marc-André Lureau wrote: > On Tue, Nov 17, 2020 at 7:49 PM Eduardo Habkost wrote: > > > On Tue, Nov 17, 2020 at 12:42:47PM +0400, Marc-André Lureau wrote: > > > On Tue, Nov 17, 2020 at 2:42 AM Eduardo Habkost > > wrote: > > > > > > > Extract the QNum

Re: [PATCH v2 4/8] qnum: qnum_value_is_equal() function

2020-11-17 Thread Marc-André Lureau
On Tue, Nov 17, 2020 at 7:49 PM Eduardo Habkost wrote: > On Tue, Nov 17, 2020 at 12:42:47PM +0400, Marc-André Lureau wrote: > > On Tue, Nov 17, 2020 at 2:42 AM Eduardo Habkost > wrote: > > > > > Extract the QNum value comparison logic to a function that takes > > > QNumValue* as argument. > > >

Re: [PATCH v2 4/8] qnum: qnum_value_is_equal() function

2020-11-17 Thread Eduardo Habkost
On Tue, Nov 17, 2020 at 12:42:47PM +0400, Marc-André Lureau wrote: > On Tue, Nov 17, 2020 at 2:42 AM Eduardo Habkost wrote: > > > Extract the QNum value comparison logic to a function that takes > > QNumValue* as argument. > > > > Signed-off-by: Eduardo Habkost > > --- > >

Re: [PATCH v2 4/8] qnum: qnum_value_is_equal() function

2020-11-17 Thread Marc-André Lureau
On Tue, Nov 17, 2020 at 2:42 AM Eduardo Habkost wrote: > Extract the QNum value comparison logic to a function that takes > QNumValue* as argument. > > Signed-off-by: Eduardo Habkost > --- > include/qapi/qmp/qnum.h | 1 + > qobject/qnum.c | 29 +++-- > 2 files

[PATCH v2 4/8] qnum: qnum_value_is_equal() function

2020-11-16 Thread Eduardo Habkost
Extract the QNum value comparison logic to a function that takes QNumValue* as argument. Signed-off-by: Eduardo Habkost --- include/qapi/qmp/qnum.h | 1 + qobject/qnum.c | 29 +++-- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git