Re: [PATCH v2 5/8] qemu/bswap: Use compiler __builtin_bswap() on Haiku

2020-10-19 Thread Philippe Mathieu-Daudé
On 9/28/20 4:18 PM, Philippe Mathieu-Daudé wrote: On 9/28/20 4:13 PM, Daniel P. Berrangé wrote: On Mon, Sep 28, 2020 at 03:09:01PM +0100, David CARLIER wrote: Unfortunately it breaks the build. Can you provide details of the errors seen and toolchain versions. I notice we don't have any CI s

Re: [PATCH v2 5/8] qemu/bswap: Use compiler __builtin_bswap() on Haiku

2020-09-28 Thread Thomas Huth
On 28/09/2020 15.19, Philippe Mathieu-Daudé wrote: > Since commit efc6c070aca ("configure: Add a test for the minimum > compiler version") the minimum compiler version required for GCC > is 4.8, which supports __builtin_bswap(). > Remove the Haiku specific ifdef'ry. > > This reverts commit 652a46e

Re: [PATCH v2 5/8] qemu/bswap: Use compiler __builtin_bswap() on Haiku

2020-09-28 Thread David CARLIER
errors as ... expected '=', ',', ';', 'asm' r "__attribute__' before "builtin_swap16' ... base gcc 8.3 On Mon, 28 Sep 2020 at 15:14, Daniel P. Berrangé wrote: > > On Mon, Sep 28, 2020 at 03:09:01PM +0100, David CARLIER wrote: > > Unfortunately it breaks the build. > > Can you provide details o

Re: [PATCH v2 5/8] qemu/bswap: Use compiler __builtin_bswap() on Haiku

2020-09-28 Thread Philippe Mathieu-Daudé
On 9/28/20 4:13 PM, Daniel P. Berrangé wrote: > On Mon, Sep 28, 2020 at 03:09:01PM +0100, David CARLIER wrote: >> Unfortunately it breaks the build. > > Can you provide details of the errors seen and toolchain versions. > > I notice we don't have any CI support for Haiku right now, nor > any reci

Re: [PATCH v2 5/8] qemu/bswap: Use compiler __builtin_bswap() on Haiku

2020-09-28 Thread Daniel P . Berrangé
On Mon, Sep 28, 2020 at 03:09:01PM +0100, David CARLIER wrote: > Unfortunately it breaks the build. Can you provide details of the errors seen and toolchain versions. I notice we don't have any CI support for Haiku right now, nor any recipe in tests/vm/ for enabling users to setup a VM with Haik

Re: [PATCH v2 5/8] qemu/bswap: Use compiler __builtin_bswap() on Haiku

2020-09-28 Thread David CARLIER
Unfortunately it breaks the build. Regards. On Mon, 28 Sep 2020 at 14:20, Philippe Mathieu-Daudé wrote: > > Since commit efc6c070aca ("configure: Add a test for the minimum > compiler version") the minimum compiler version required for GCC > is 4.8, which supports __builtin_bswap(). > Remove the

[PATCH v2 5/8] qemu/bswap: Use compiler __builtin_bswap() on Haiku

2020-09-28 Thread Philippe Mathieu-Daudé
Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8, which supports __builtin_bswap(). Remove the Haiku specific ifdef'ry. This reverts commit 652a46ebba970017c7a23767dcc983265cdb8eb7 ("bswap.h: Include on Haiku