Re: [PATCH v3] acpi: Permit OEM ID and OEM table ID fields to be changed

2021-01-13 Thread Michael S. Tsirkin
On Mon, Jan 11, 2021 at 04:59:54PM +0200, Marian Posteuca wrote: > Igor Mammedov writes: > > > overall looks good. > > Please add a test case for it, see > > tests/qtest/bios-tables-test.c for description how to do it > > an/or at > > "[PATCH v3 08/12] tests/acpi: allow updates for expected

Re: [PATCH v3] acpi: Permit OEM ID and OEM table ID fields to be changed

2021-01-11 Thread Igor Mammedov
On Mon, 11 Jan 2021 16:59:54 +0200 Marian Posteuca wrote: > Igor Mammedov writes: > > > overall looks good. > > Please add a test case for it, see > > tests/qtest/bios-tables-test.c for description how to do it > > an/or at > > "[PATCH v3 08/12] tests/acpi: allow updates for expected data

Re: [PATCH v3] acpi: Permit OEM ID and OEM table ID fields to be changed

2021-01-11 Thread Marian Posteuca
Igor Mammedov writes: > overall looks good. > Please add a test case for it, see > tests/qtest/bios-tables-test.c for description how to do it > an/or at > "[PATCH v3 08/12] tests/acpi: allow updates for expected data files" > and follow up patches on the list. When you say add a test case, do

Re: [PATCH v3] acpi: Permit OEM ID and OEM table ID fields to be changed

2021-01-06 Thread Igor Mammedov
On Thu, 31 Dec 2020 00:13:01 +0200 Marian Posteuca wrote: > Qemu's ACPI table generation sets the fields OEM ID and OEM table ID > to "BOCHS " and "BXPC" where "" is replaced by the ACPI > table name. > > Some games like Red Dead Redemption 2 seem to check the ACPI OEM ID > and OEM

[PATCH v3] acpi: Permit OEM ID and OEM table ID fields to be changed

2020-12-30 Thread Marian Posteuca
Qemu's ACPI table generation sets the fields OEM ID and OEM table ID to "BOCHS " and "BXPC" where "" is replaced by the ACPI table name. Some games like Red Dead Redemption 2 seem to check the ACPI OEM ID and OEM table ID for the strings "BOCHS" and "BXPC" and if they are found, the game