Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-27 Thread Igor Mammedov
On Mon, 25 Jul 2022 16:59:21 +0300 Vladimir Sementsov-Ogievskiy wrote: > On 7/20/22 14:04, Daniel P. Berrangé wrote: > > On Wed, Jul 20, 2022 at 02:00:16PM +0300, Roman Kagan wrote: > >> On Wed, Jul 20, 2022 at 11:44:26AM +0100, Daniel P. Berrangé wrote: > >>> On Wed, Jul 20, 2022 at 01:25:55

Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-25 Thread Vladimir Sementsov-Ogievskiy
On 7/20/22 14:04, Daniel P. Berrangé wrote: On Wed, Jul 20, 2022 at 02:00:16PM +0300, Roman Kagan wrote: On Wed, Jul 20, 2022 at 11:44:26AM +0100, Daniel P. Berrangé wrote: On Wed, Jul 20, 2022 at 01:25:55PM +0300, Roman Kagan wrote: It's possible to create non-working configurations by attach

Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-22 Thread Mark Cave-Ayland
On 22/07/2022 08:28, Thomas Huth wrote: On 21/07/2022 18.05, Mark Cave-Ayland wrote: On 21/07/2022 16:56, Daniel P. Berrangé wrote: On Thu, Jul 21, 2022 at 04:51:51PM +0100, Mark Cave-Ayland wrote: On 21/07/2022 15:28, Roman Kagan wrote: (lots cut) In the guest (Fedora 34): [root@test ~]

Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-22 Thread Thomas Huth
On 21/07/2022 18.05, Mark Cave-Ayland wrote: On 21/07/2022 16:56, Daniel P. Berrangé wrote: On Thu, Jul 21, 2022 at 04:51:51PM +0100, Mark Cave-Ayland wrote: On 21/07/2022 15:28, Roman Kagan wrote: (lots cut) In the guest (Fedora 34): [root@test ~]# lspci -tv -[:00]-+-00.0  Intel Corpo

Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-21 Thread Daniel P . Berrangé
On Thu, Jul 21, 2022 at 05:05:38PM +0100, Mark Cave-Ayland wrote: > On 21/07/2022 16:56, Daniel P. Berrangé wrote: > > > On Thu, Jul 21, 2022 at 04:51:51PM +0100, Mark Cave-Ayland wrote: > > > On 21/07/2022 15:28, Roman Kagan wrote: > > > > > > (lots cut) > > > > > > > In the guest (Fedora 34):

Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-21 Thread Mark Cave-Ayland
On 21/07/2022 16:56, Daniel P. Berrangé wrote: On Thu, Jul 21, 2022 at 04:51:51PM +0100, Mark Cave-Ayland wrote: On 21/07/2022 15:28, Roman Kagan wrote: (lots cut) In the guest (Fedora 34): [root@test ~]# lspci -tv -[:00]-+-00.0 Intel Corporation 82G33/G31/P35/P31 Express DRAM Controll

Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-21 Thread Roman Kagan
On Thu, Jul 21, 2022 at 05:05:38PM +0100, Mark Cave-Ayland wrote: > On 21/07/2022 16:56, Daniel P. Berrangé wrote: > > > On Thu, Jul 21, 2022 at 04:51:51PM +0100, Mark Cave-Ayland wrote: > > > On 21/07/2022 15:28, Roman Kagan wrote: > > > > > > (lots cut) > > > > > > > In the guest (Fedora 34):

Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-21 Thread Daniel P . Berrangé
On Thu, Jul 21, 2022 at 04:51:51PM +0100, Mark Cave-Ayland wrote: > On 21/07/2022 15:28, Roman Kagan wrote: > > (lots cut) > > > In the guest (Fedora 34): > > > > [root@test ~]# lspci -tv > > -[:00]-+-00.0 Intel Corporation 82G33/G31/P35/P31 Express DRAM > > Controller > > +-01

Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-21 Thread Mark Cave-Ayland
On 21/07/2022 15:28, Roman Kagan wrote: (lots cut) In the guest (Fedora 34): [root@test ~]# lspci -tv -[:00]-+-00.0 Intel Corporation 82G33/G31/P35/P31 Express DRAM Controller +-01.0 Device 1234: +-02.0 Red Hat, Inc. QEMU XHCI Host Controller +-05

Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-21 Thread Roman Kagan
On Wed, Jul 20, 2022 at 02:21:38PM +0100, Mark Cave-Ayland wrote: > On 20/07/2022 12:00, Roman Kagan wrote: > > > On Wed, Jul 20, 2022 at 11:44:26AM +0100, Daniel P. Berrangé wrote: > > > On Wed, Jul 20, 2022 at 01:25:55PM +0300, Roman Kagan wrote: > > > > It's possible to create non-working confi

Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-20 Thread Mark Cave-Ayland
On 20/07/2022 12:00, Roman Kagan wrote: On Wed, Jul 20, 2022 at 11:44:26AM +0100, Daniel P. Berrangé wrote: On Wed, Jul 20, 2022 at 01:25:55PM +0300, Roman Kagan wrote: It's possible to create non-working configurations by attaching a device to a derivative of PCIe slot (pcie-root-port, ioh342

Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-20 Thread Roman Kagan
On Wed, Jul 20, 2022 at 12:04:58PM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 20, 2022 at 02:00:16PM +0300, Roman Kagan wrote: > > On Wed, Jul 20, 2022 at 11:44:26AM +0100, Daniel P. Berrangé wrote: > > > On Wed, Jul 20, 2022 at 01:25:55PM +0300, Roman Kagan wrote: > > > > It's possible to crea

Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-20 Thread Daniel P . Berrangé
On Wed, Jul 20, 2022 at 02:00:16PM +0300, Roman Kagan wrote: > On Wed, Jul 20, 2022 at 11:44:26AM +0100, Daniel P. Berrangé wrote: > > On Wed, Jul 20, 2022 at 01:25:55PM +0300, Roman Kagan wrote: > > > It's possible to create non-working configurations by attaching a device > > > to a derivative of

Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-20 Thread Roman Kagan
On Wed, Jul 20, 2022 at 11:44:26AM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 20, 2022 at 01:25:55PM +0300, Roman Kagan wrote: > > It's possible to create non-working configurations by attaching a device > > to a derivative of PCIe slot (pcie-root-port, ioh3420, etc) and > > specifying a slot n

Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-20 Thread Daniel P . Berrangé
On Wed, Jul 20, 2022 at 01:25:55PM +0300, Roman Kagan wrote: > It's possible to create non-working configurations by attaching a device > to a derivative of PCIe slot (pcie-root-port, ioh3420, etc) and > specifying a slot number other that zero, e.g.: > > -device pcie-root-port,id=s0,... \ >

Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-20 Thread Thomas Huth
On 20/07/2022 12.25, Roman Kagan wrote: It's possible to create non-working configurations by attaching a device to a derivative of PCIe slot (pcie-root-port, ioh3420, etc) and specifying a slot number other that zero, e.g.: -device pcie-root-port,id=s0,... \ -device virtio-blk-pci,bus

[PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-20 Thread Roman Kagan
It's possible to create non-working configurations by attaching a device to a derivative of PCIe slot (pcie-root-port, ioh3420, etc) and specifying a slot number other that zero, e.g.: -device pcie-root-port,id=s0,... \ -device virtio-blk-pci,bus=s0,addr=4,... Make QEMU reject such config