Re: [PATCH v3] vhost: make SET_VRING_ADDR, SET_FEATURES send replies

2021-08-09 Thread Denis Plotnikov
On 09.08.2021 12:34, Michael S. Tsirkin wrote: Looks good. Some cosmetics: all comments addressed in already sent v4 On Mon, Aug 09, 2021 at 12:03:30PM +0300, Denis Plotnikov wrote: On vhost-user-blk migration, qemu normally sends a number of commands to enable logging if

Re: [PATCH v3] vhost: make SET_VRING_ADDR, SET_FEATURES send replies

2021-08-09 Thread Michael S. Tsirkin
Looks good. Some cosmetics: On Mon, Aug 09, 2021 at 12:03:30PM +0300, Denis Plotnikov wrote: > On vhost-user-blk migration, qemu normally sends a number of commands > to enable logging if VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated. > Qemu sends VHOST_USER_SET_FEATURES to enable buffers logging

[PATCH v3] vhost: make SET_VRING_ADDR, SET_FEATURES send replies

2021-08-09 Thread Denis Plotnikov
On vhost-user-blk migration, qemu normally sends a number of commands to enable logging if VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated. Qemu sends VHOST_USER_SET_FEATURES to enable buffers logging and VHOST_USER_SET_VRING_ADDR per each started ring to enable "used ring" data logging. The issue