Re: [PATCH v3 00/12] gdbstub and TCG plugin improvements

2023-09-14 Thread Philippe Mathieu-Daudé

On 14/9/23 17:56, Alex Bennée wrote:


Akihiko Odaki  writes:


This series extracts fixes and refactorings that can be applied
independently from "[PATCH RESEND v5 00/26] plugins: Allow to read
registers" as suggested by Nicholas Piggin.

Patch "target/ppc: Remove references to gdb_has_xml" is also updated to
remove some dead code I missed earlier and thus the Reviewed-by tag is
dropped.


Queued to gdbstub/next, thanks.


I left a comment in patch #3:
https://lore.kernel.org/qemu-devel/bf33447c-119f-c4b9-5f80-d4ad6169c...@linaro.org/

If you agree with the comment I can send a patch to replace so
you can keep this series queued.

Regards,

Phil.



Re: [PATCH v3 00/12] gdbstub and TCG plugin improvements

2023-09-14 Thread Alex Bennée


Akihiko Odaki  writes:

> This series extracts fixes and refactorings that can be applied
> independently from "[PATCH RESEND v5 00/26] plugins: Allow to read
> registers" as suggested by Nicholas Piggin.
>
> Patch "target/ppc: Remove references to gdb_has_xml" is also updated to
> remove some dead code I missed earlier and thus the Reviewed-by tag is
> dropped.

Queued to gdbstub/next, thanks.

>
> V2 -> V3:
>   Added patch "plugins: Check if vCPU is realized".
>
> V1 -> V2:
>   Rebased.
>   Added patch "gdbstub: Fix target_xml initialization".
>   Added patch "gdbstub: Fix target.xml response".
>   Added patch "gdbstub: Replace gdb_regs with an array".
>
> Akihiko Odaki (12):
>   gdbstub: Fix target_xml initialization
>   gdbstub: Fix target.xml response
>   plugins: Check if vCPU is realized
>   contrib/plugins: Use GRWLock in execlog
>   gdbstub: Introduce GDBFeature structure
>   target/arm: Move the reference to arm-core.xml
>   hw/core/cpu: Return static value with gdb_arch_name()
>   gdbstub: Use g_markup_printf_escaped()
>   target/arm: Remove references to gdb_has_xml
>   target/ppc: Remove references to gdb_has_xml
>   gdbstub: Remove gdb_has_xml variable
>   gdbstub: Replace gdb_regs with an array
>
>  MAINTAINERS   |  2 +-
>  meson.build   |  2 +-
>  gdbstub/internals.h   |  2 -
>  include/exec/gdbstub.h| 17 +++
>  include/hw/core/cpu.h |  4 +-
>  target/ppc/internal.h |  2 +-
>  contrib/plugins/execlog.c | 16 ---
>  gdbstub/gdbstub.c | 94 +++
>  gdbstub/softmmu.c |  2 +-
>  plugins/core.c|  2 +-
>  stubs/gdbstub.c   |  6 +--
>  target/arm/cpu.c  |  9 ++--
>  target/arm/cpu64.c|  4 +-
>  target/arm/gdbstub.c  | 32 +
>  target/i386/cpu.c |  6 +--
>  target/loongarch/cpu.c|  8 ++--
>  target/ppc/gdbstub.c  | 24 ++
>  target/riscv/cpu.c|  6 +--
>  target/s390x/cpu.c|  4 +-
>  target/tricore/cpu.c  |  4 +-
>  scripts/feature_to_c.py   | 48 
>  scripts/feature_to_c.sh   | 69 
>  22 files changed, 146 insertions(+), 217 deletions(-)
>  create mode 100755 scripts/feature_to_c.py
>  delete mode 100644 scripts/feature_to_c.sh


-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro



[PATCH v3 00/12] gdbstub and TCG plugin improvements

2023-09-12 Thread Akihiko Odaki
This series extracts fixes and refactorings that can be applied
independently from "[PATCH RESEND v5 00/26] plugins: Allow to read
registers" as suggested by Nicholas Piggin.

Patch "target/ppc: Remove references to gdb_has_xml" is also updated to
remove some dead code I missed earlier and thus the Reviewed-by tag is
dropped.

V2 -> V3:
  Added patch "plugins: Check if vCPU is realized".

V1 -> V2:
  Rebased.
  Added patch "gdbstub: Fix target_xml initialization".
  Added patch "gdbstub: Fix target.xml response".
  Added patch "gdbstub: Replace gdb_regs with an array".

Akihiko Odaki (12):
  gdbstub: Fix target_xml initialization
  gdbstub: Fix target.xml response
  plugins: Check if vCPU is realized
  contrib/plugins: Use GRWLock in execlog
  gdbstub: Introduce GDBFeature structure
  target/arm: Move the reference to arm-core.xml
  hw/core/cpu: Return static value with gdb_arch_name()
  gdbstub: Use g_markup_printf_escaped()
  target/arm: Remove references to gdb_has_xml
  target/ppc: Remove references to gdb_has_xml
  gdbstub: Remove gdb_has_xml variable
  gdbstub: Replace gdb_regs with an array

 MAINTAINERS   |  2 +-
 meson.build   |  2 +-
 gdbstub/internals.h   |  2 -
 include/exec/gdbstub.h| 17 +++
 include/hw/core/cpu.h |  4 +-
 target/ppc/internal.h |  2 +-
 contrib/plugins/execlog.c | 16 ---
 gdbstub/gdbstub.c | 94 +++
 gdbstub/softmmu.c |  2 +-
 plugins/core.c|  2 +-
 stubs/gdbstub.c   |  6 +--
 target/arm/cpu.c  |  9 ++--
 target/arm/cpu64.c|  4 +-
 target/arm/gdbstub.c  | 32 +
 target/i386/cpu.c |  6 +--
 target/loongarch/cpu.c|  8 ++--
 target/ppc/gdbstub.c  | 24 ++
 target/riscv/cpu.c|  6 +--
 target/s390x/cpu.c|  4 +-
 target/tricore/cpu.c  |  4 +-
 scripts/feature_to_c.py   | 48 
 scripts/feature_to_c.sh   | 69 
 22 files changed, 146 insertions(+), 217 deletions(-)
 create mode 100755 scripts/feature_to_c.py
 delete mode 100644 scripts/feature_to_c.sh

-- 
2.42.0