RE: [PATCH v3 02/15] hw/block/nvme: Report actual LBA data shift in LBAF

2020-09-15 Thread Dmitry Fomichev
u-bl...@nongnu.org; qemu-devel@nongnu.org; Alistair Francis > ; Matias Bjorling > Subject: Re: [PATCH v3 02/15] hw/block/nvme: Report actual LBA data shift in > LBAF > > On Sep 14 07:14, Dmitry Fomichev wrote: > > Calculate the data shift value to report based on the

Re: [PATCH v3 02/15] hw/block/nvme: Report actual LBA data shift in LBAF

2020-09-15 Thread Klaus Jensen
On Sep 14 07:14, Dmitry Fomichev wrote: > Calculate the data shift value to report based on the set value of > logical_block_size device property. > > In the process, use a local variable to calculate the LBA format > index instead of the hardcoded value 0. This makes the code more > readable and

[PATCH v3 02/15] hw/block/nvme: Report actual LBA data shift in LBAF

2020-09-13 Thread Dmitry Fomichev
Calculate the data shift value to report based on the set value of logical_block_size device property. In the process, use a local variable to calculate the LBA format index instead of the hardcoded value 0. This makes the code more readable and it will make it easier to add support for multiple