Re: [PATCH v3 05/34] tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers

2020-03-16 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Sun, Mar 15, 2020 at 3:48 PM Markus Armbruster wrote: >> >> Checking the value of qmp_dispatch() is repetitive. Factor out >> helpers do_qmp_dispatch() and do_qmp_dispatch_error(). Without this, >> the next commit would make things even more repetitive.

Re: [PATCH v3 05/34] tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers

2020-03-16 Thread Eric Blake
On 3/15/20 9:46 AM, Markus Armbruster wrote: Checking the value of qmp_dispatch() is repetitive. Factor out helpers do_qmp_dispatch() and do_qmp_dispatch_error(). Without this, the next commit would make things even more repetitive. Signed-off-by: Markus Armbruster ---

Re: [PATCH v3 05/34] tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers

2020-03-16 Thread Marc-André Lureau
Hi On Sun, Mar 15, 2020 at 3:48 PM Markus Armbruster wrote: > > Checking the value of qmp_dispatch() is repetitive. Factor out > helpers do_qmp_dispatch() and do_qmp_dispatch_error(). Without this, > the next commit would make things even more repetitive. > > Signed-off-by: Markus Armbruster

[PATCH v3 05/34] tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers

2020-03-15 Thread Markus Armbruster
Checking the value of qmp_dispatch() is repetitive. Factor out helpers do_qmp_dispatch() and do_qmp_dispatch_error(). Without this, the next commit would make things even more repetitive. Signed-off-by: Markus Armbruster --- tests/test-qmp-cmds.c | 72