Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration

2021-06-28 Thread Daniel P . Berrangé
On Mon, Jun 28, 2021 at 03:12:33PM +0200, Alexander Graf wrote: > > On 28.06.21 13:28, Dr. David Alan Gilbert wrote: > > * Alexander Graf (ag...@csgraf.de) wrote: > >> On 14.06.21 13:57, Dr. David Alan Gilbert wrote: > >>> cc'ing in qemu-stable - I think we'd probably want this on 6.0 > >>> (It's

Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration

2021-06-28 Thread Alexander Graf
On 28.06.21 13:28, Dr. David Alan Gilbert wrote: > * Alexander Graf (ag...@csgraf.de) wrote: >> On 14.06.21 13:57, Dr. David Alan Gilbert wrote: >>> cc'ing in qemu-stable - I think we'd probably want this on 6.0 >>> (It's currently merged as 7de2e8565335c13fb3516cddbe2e40e366cce273 ). >>>

Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration

2021-06-28 Thread Dr. David Alan Gilbert
* Alexander Graf (ag...@csgraf.de) wrote: > > On 14.06.21 13:57, Dr. David Alan Gilbert wrote: > > cc'ing in qemu-stable - I think we'd probably want this on 6.0 > > (It's currently merged as 7de2e8565335c13fb3516cddbe2e40e366cce273 ). > > Although you'll probably also want the missing dependency

Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration

2021-06-27 Thread Alexander Graf
On 14.06.21 13:57, Dr. David Alan Gilbert wrote: > cc'ing in qemu-stable - I think we'd probably want this on 6.0 > (It's currently merged as 7de2e8565335c13fb3516cddbe2e40e366cce273 ). > Although you'll probably also want the missing dependency fix > Philippe is working (See: > Mathieu- ( 42)

Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration

2021-06-14 Thread Dr. David Alan Gilbert
cc'ing in qemu-stable - I think we'd probably want this on 6.0 (It's currently merged as 7de2e8565335c13fb3516cddbe2e40e366cce273 ). Although you'll probably also want the missing dependency fix Philippe is working (See: Mathieu- ( 42) [RFC PATCH] migration: Add missing dependency on GNUTLS )

Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration

2021-06-08 Thread Dr. David Alan Gilbert
* Leonardo Bras (leobra...@gmail.com) wrote: > After yank feature was introduced in migration, whenever migration > is started using TLS, the following error happens in both source and > destination hosts: > > (qemu) qemu-kvm: ../util/yank.c:107: yank_unregister_instance: > Assertion

Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration

2021-06-01 Thread Leonardo Brás
On Tue, 2021-06-01 at 10:50 -0400, Peter Xu wrote: > On Tue, Jun 01, 2021 at 02:40:31AM -0300, Leonardo Bras wrote: > > [...] > > inside migration_channel_connect() and > > migration_channel_process_incoming() move yank_register_function() > > so > > it only runs once on a TLS migration. > >

Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration

2021-06-01 Thread Leonardo Brás
On Tue, 2021-06-01 at 13:00 +0200, Lukas Straub wrote: > [...] > Looks good to me, > Reviewed-by: Lukas Straub > Thanks!

Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration

2021-06-01 Thread Peter Xu
On Tue, Jun 01, 2021 at 05:32:33PM +0200, Lukas Straub wrote: > > I have one pure question not directly related to Leo's patch (probably for > > Lukas?): we check OBJECT(ioc)->ref == 1 when unregister each function. In > > what > > case will the ref be not one? > > > > If a return path is

Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration

2021-06-01 Thread Lukas Straub
On Tue, 1 Jun 2021 10:50:24 -0400 Peter Xu wrote: > On Tue, Jun 01, 2021 at 02:40:31AM -0300, Leonardo Bras wrote: > > After yank feature was introduced in migration, whenever migration > > is started using TLS, the following error happens in both source and > > destination hosts: > > > >

Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration

2021-06-01 Thread Peter Xu
On Tue, Jun 01, 2021 at 02:40:31AM -0300, Leonardo Bras wrote: > After yank feature was introduced in migration, whenever migration > is started using TLS, the following error happens in both source and > destination hosts: > > (qemu) qemu-kvm: ../util/yank.c:107: yank_unregister_instance: >

Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration

2021-06-01 Thread Lukas Straub
On Tue, 1 Jun 2021 02:40:31 -0300 Leonardo Bras wrote: > After yank feature was introduced in migration, whenever migration > is started using TLS, the following error happens in both source and > destination hosts: > > (qemu) qemu-kvm: ../util/yank.c:107: yank_unregister_instance: > Assertion

[PATCH v3 1/1] yank: Unregister function when using TLS migration

2021-05-31 Thread Leonardo Bras
After yank feature was introduced in migration, whenever migration is started using TLS, the following error happens in both source and destination hosts: (qemu) qemu-kvm: ../util/yank.c:107: yank_unregister_instance: Assertion `QLIST_EMPTY(>yankfns)' failed. This happens because of a missing