Re: [PATCH v3 1/3] Acceptance test: adds param 'address' in _get_free_port
On Fri, Mar 20, 2020 at 12:15 PM Oksana Vohchana wrote:
>
> In the migration test function _get_free_port works only for localhost,
> but in the case to use migration through an RDMA we need to get a free port
> on the configured network RDMA-interface.
> This patch is the start for another migration option
>
> Signed-off-by: Oksana Vohchana
> ---
> tests/acceptance/migration.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py
> index a8367ca023..e4c39b85a1 100644
> --- a/tests/acceptance/migration.py
> +++ b/tests/acceptance/migration.py
> @@ -52,8 +52,8 @@ class Migration(Test):
> source_vm.qmp('migrate', uri=src_uri)
> self.assert_migration(source_vm, dest_vm)
>
> -def _get_free_port(self):
> -port = network.find_free_port()
> +def _get_free_port(self, address='localhost'):
> +port = network.find_free_port(address=address)
> if port is None:
> self.cancel('Failed to find a free port')
> return port
> --
> 2.21.1
>
>
Reviewed-by: Willian Rampazzo
[PATCH v3 1/3] Acceptance test: adds param 'address' in _get_free_port
In the migration test function _get_free_port works only for localhost,
but in the case to use migration through an RDMA we need to get a free port
on the configured network RDMA-interface.
This patch is the start for another migration option
Signed-off-by: Oksana Vohchana
---
tests/acceptance/migration.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py
index a8367ca023..e4c39b85a1 100644
--- a/tests/acceptance/migration.py
+++ b/tests/acceptance/migration.py
@@ -52,8 +52,8 @@ class Migration(Test):
source_vm.qmp('migrate', uri=src_uri)
self.assert_migration(source_vm, dest_vm)
-def _get_free_port(self):
-port = network.find_free_port()
+def _get_free_port(self, address='localhost'):
+port = network.find_free_port(address=address)
if port is None:
self.cancel('Failed to find a free port')
return port
--
2.21.1
