Re: [PATCH v3 1/8] tpm_tis: Allow lowering of IRQ also when locality is not active

2020-06-17 Thread Marc-André Lureau 
On Wed, Jun 17, 2020 at 12:57 AM Stefan Berger
 wrote:
>
> From: Stefan Berger 
>
> This patch fixes a bug that occurs when using interrupts. It
> allows to lower the IRQ also when a locality is not active.
>
> Signed-off-by: Stefan Berger 
> Reviewed-by: Eric Auger 

Reviewed-by: Marc-André Lureau 

> ---
>  hw/tpm/tpm_tis_common.c | 4 
>  1 file changed, 4 deletions(-)
>
> diff --git a/hw/tpm/tpm_tis_common.c b/hw/tpm/tpm_tis_common.c
> index 1af4bce139..0f42696f1f 100644
> --- a/hw/tpm/tpm_tis_common.c
> +++ b/hw/tpm/tpm_tis_common.c
> @@ -601,10 +601,6 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
>  /* hard wired -- ignore */
>  break;
>  case TPM_TIS_REG_INT_STATUS:
> -if (s->active_locty != locty) {
> -break;
> -}
> -
>  /* clearing of interrupt flags */
>  if (((val & TPM_TIS_INTERRUPTS_SUPPORTED)) &&
>  (s->loc[locty].ints & TPM_TIS_INTERRUPTS_SUPPORTED)) {
> --
> 2.24.1
>

[PATCH v3 1/8] tpm_tis: Allow lowering of IRQ also when locality is not active

2020-06-16 Thread Stefan Berger 
From: Stefan Berger 

This patch fixes a bug that occurs when using interrupts. It
allows to lower the IRQ also when a locality is not active.

Signed-off-by: Stefan Berger 
Reviewed-by: Eric Auger 
---
 hw/tpm/tpm_tis_common.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/hw/tpm/tpm_tis_common.c b/hw/tpm/tpm_tis_common.c
index 1af4bce139..0f42696f1f 100644
--- a/hw/tpm/tpm_tis_common.c
+++ b/hw/tpm/tpm_tis_common.c
@@ -601,10 +601,6 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
 /* hard wired -- ignore */
 break;
 case TPM_TIS_REG_INT_STATUS:
-if (s->active_locty != locty) {
-break;
-}
-
 /* clearing of interrupt flags */
 if (((val & TPM_TIS_INTERRUPTS_SUPPORTED)) &&
 (s->loc[locty].ints & TPM_TIS_INTERRUPTS_SUPPORTED)) {
-- 
2.24.1