Re: [PATCH v3 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

2020-10-20 Thread Vladimir Sementsov-Ogievskiy
19.10.2020 16:06, Kevin Wolf wrote: Am 16.10.2020 um 19:10 hat Vladimir Sementsov-Ogievskiy geschrieben: qcow2_do_open correctly sets errp on each failure path. So, we can simplify code in qcow2_co_invalidate_cache() and drop explicit error propagation. qcow2_update_options_prepare() can

Re: [PATCH v3 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

2020-10-19 Thread Kevin Wolf
Am 16.10.2020 um 19:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > qcow2_do_open correctly sets errp on each failure path. So, we can > simplify code in qcow2_co_invalidate_cache() and drop explicit error > propagation. qcow2_update_options_prepare() can return -EINVAL without setting errp:

[PATCH v3 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

2020-10-16 Thread Vladimir Sementsov-Ogievskiy
qcow2_do_open correctly sets errp on each failure path. So, we can simplify code in qcow2_co_invalidate_cache() and drop explicit error propagation. Add ERRP_GUARD() as mandated by the documentation in include/qapi/error.h so that error_prepend() is actually called even if errp is _fatal.