Re: [PATCH v3 15/16] hw/i386/vmport: Add support for CMD_GETHZ

2020-03-14 Thread Liran Alon
On 14/03/2020 23:52, Michael S. Tsirkin wrote: On Sat, Mar 14, 2020 at 12:44:55AM +0200, Liran Alon wrote: On 13/03/2020 22:07, Philippe Mathieu-Daudé wrote: On 3/12/20 5:54 PM, Liran Alon wrote: diff --git a/include/hw/i386/vmport.h b/include/hw/i386/vmport.h index

Re: [PATCH v3 15/16] hw/i386/vmport: Add support for CMD_GETHZ

2020-03-14 Thread Michael S. Tsirkin
On Sat, Mar 14, 2020 at 12:44:55AM +0200, Liran Alon wrote: > > On 13/03/2020 22:07, Philippe Mathieu-Daudé wrote: > > On 3/12/20 5:54 PM, Liran Alon wrote: > > > > > > diff --git a/include/hw/i386/vmport.h b/include/hw/i386/vmport.h > > > index 34cc050b1ffa..aee809521aa0 100644 > > > ---

Re: [PATCH v3 15/16] hw/i386/vmport: Add support for CMD_GETHZ

2020-03-14 Thread Philippe Mathieu-Daudé
On 3/13/20 11:44 PM, Liran Alon wrote: On 13/03/2020 22:07, Philippe Mathieu-Daudé wrote: On 3/12/20 5:54 PM, Liran Alon wrote: diff --git a/include/hw/i386/vmport.h b/include/hw/i386/vmport.h index 34cc050b1ffa..aee809521aa0 100644 --- a/include/hw/i386/vmport.h +++

Re: [PATCH v3 15/16] hw/i386/vmport: Add support for CMD_GETHZ

2020-03-13 Thread Liran Alon
On 13/03/2020 22:07, Philippe Mathieu-Daudé wrote: On 3/12/20 5:54 PM, Liran Alon wrote: diff --git a/include/hw/i386/vmport.h b/include/hw/i386/vmport.h index 34cc050b1ffa..aee809521aa0 100644 --- a/include/hw/i386/vmport.h +++ b/include/hw/i386/vmport.h @@ -12,6 +12,7 @@ typedef enum {

Re: [PATCH v3 15/16] hw/i386/vmport: Add support for CMD_GETHZ

2020-03-13 Thread Philippe Mathieu-Daudé
On 3/12/20 5:54 PM, Liran Alon wrote: This command returns to guest information on LAPIC bus frequency and TSC frequency. One can see how this interface is used by Linux vmware_platform_setup() introduced in Linux commit 88b094fb8d4f ("x86: Hypervisor detection and get tsc_freq from

[PATCH v3 15/16] hw/i386/vmport: Add support for CMD_GETHZ

2020-03-12 Thread Liran Alon
This command returns to guest information on LAPIC bus frequency and TSC frequency. One can see how this interface is used by Linux vmware_platform_setup() introduced in Linux commit 88b094fb8d4f ("x86: Hypervisor detection and get tsc_freq from hypervisor"). Reviewed-by: Nikita Leshenko