Re: [PATCH v4 03/17] target/ppc: Properly sync cpu state with new msr in cpu_load_old

2021-03-22 Thread David Gibson
On Mon, Mar 22, 2021 at 10:53:01AM -0600, Richard Henderson wrote: > On 3/16/21 2:15 AM, Cédric Le Goater wrote: > > On 3/15/21 7:46 PM, Richard Henderson wrote: > > > Match cpu_post_load in using ppc_store_msr to set all of > > > the cpu state implied by the value of msr. Do not restore > > >

Re: [PATCH v4 03/17] target/ppc: Properly sync cpu state with new msr in cpu_load_old

2021-03-22 Thread Richard Henderson
On 3/16/21 2:15 AM, Cédric Le Goater wrote: On 3/15/21 7:46 PM, Richard Henderson wrote: Match cpu_post_load in using ppc_store_msr to set all of the cpu state implied by the value of msr. Do not restore hflags or hflags_nmsr, as we recompute them in ppc_store_msr. Signed-off-by: Richard

Re: [PATCH v4 03/17] target/ppc: Properly sync cpu state with new msr in cpu_load_old

2021-03-21 Thread David Gibson
On Mon, Mar 15, 2021 at 12:46:01PM -0600, Richard Henderson wrote: > Match cpu_post_load in using ppc_store_msr to set all of > the cpu state implied by the value of msr. Do not restore > hflags or hflags_nmsr, as we recompute them in ppc_store_msr. > > Signed-off-by: Richard Henderson Applied

Re: [PATCH v4 03/17] target/ppc: Properly sync cpu state with new msr in cpu_load_old

2021-03-16 Thread Cédric Le Goater
On 3/15/21 7:46 PM, Richard Henderson wrote: > Match cpu_post_load in using ppc_store_msr to set all of > the cpu state implied by the value of msr. Do not restore > hflags or hflags_nmsr, as we recompute them in ppc_store_msr. > > Signed-off-by: Richard Henderson Could we add a common routine

[PATCH v4 03/17] target/ppc: Properly sync cpu state with new msr in cpu_load_old

2021-03-15 Thread Richard Henderson
Match cpu_post_load in using ppc_store_msr to set all of the cpu state implied by the value of msr. Do not restore hflags or hflags_nmsr, as we recompute them in ppc_store_msr. Signed-off-by: Richard Henderson --- target/ppc/machine.c | 13 +++-- 1 file changed, 11 insertions(+), 2