Re: [PATCH v4 15/18] tests/docker: updates to alpine package list
On 11/24/21 14:01, Daniel P. Berrangé wrote: > Cleanup the package lists by removing some entries that we don't need to > directly reference > > binutils: implied by the compiler toolchain > coreutils: not required by QEMU build > mesa-egl mesa-gbm: implied by mesa-dev > ninja: alias for samurai package I'd rather keep the alias to avoid looking for ninja or for what samurai is. Anyhow, Reviewed-by: Philippe Mathieu-Daudé > shadow: not required by QEMU build > util-linux-dev: not directly required by QEMU build > > Signed-off-by: Daniel P. Berrangé > --- > tests/docker/dockerfiles/alpine.docker | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-)
Re: [PATCH v4 15/18] tests/docker: updates to alpine package list
On Wed, Dec 15, 2021 at 12:31:33PM +0100, Philippe Mathieu-Daudé wrote: > On 11/24/21 14:01, Daniel P. Berrangé wrote: > > Cleanup the package lists by removing some entries that we don't need to > > directly reference > > > > binutils: implied by the compiler toolchain > > coreutils: not required by QEMU build > > mesa-egl mesa-gbm: implied by mesa-dev > > ninja: alias for samurai package > > I'd rather keep the alias to avoid looking for ninja or > for what samurai is. Anyhow, This change was done to align with the package lists that lcitool will generate. In lcitool we always aim to use the canonical package name, rather than any alias, so it is explicit what impl we're using for something. > Reviewed-by: Philippe Mathieu-Daudé > > > shadow: not required by QEMU build > > util-linux-dev: not directly required by QEMU build > > > > Signed-off-by: Daniel P. Berrangé > > --- > > tests/docker/dockerfiles/alpine.docker | 8 +--- > > 1 file changed, 1 insertion(+), 7 deletions(-) > Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
Re: [PATCH v4 15/18] tests/docker: updates to alpine package list
On 12/15/21 12:43, Daniel P. Berrangé wrote: > On Wed, Dec 15, 2021 at 12:31:33PM +0100, Philippe Mathieu-Daudé wrote: >> On 11/24/21 14:01, Daniel P. Berrangé wrote: >>> Cleanup the package lists by removing some entries that we don't need to >>> directly reference >>> >>> binutils: implied by the compiler toolchain >>> coreutils: not required by QEMU build >>> mesa-egl mesa-gbm: implied by mesa-dev >>> ninja: alias for samurai package >> >> I'd rather keep the alias to avoid looking for ninja or >> for what samurai is. Anyhow, > > This change was done to align with the package lists that > lcitool will generate. In lcitool we always aim to use the > canonical package name, rather than any alias, so it is > explicit what impl we're using for something. OK then. >> Reviewed-by: Philippe Mathieu-Daudé
[PATCH v4 15/18] tests/docker: updates to alpine package list
Cleanup the package lists by removing some entries that we don't need to directly reference binutils: implied by the compiler toolchain coreutils: not required by QEMU build mesa-egl mesa-gbm: implied by mesa-dev ninja: alias for samurai package shadow: not required by QEMU build util-linux-dev: not directly required by QEMU build Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/alpine.docker | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/tests/docker/dockerfiles/alpine.docker b/tests/docker/dockerfiles/alpine.docker index 7e6997e301..5a1808726e 100644 --- a/tests/docker/dockerfiles/alpine.docker +++ b/tests/docker/dockerfiles/alpine.docker @@ -8,9 +8,7 @@ RUN apk upgrade ENV PACKAGES \ alsa-lib-dev \ bash \ - binutils \ ccache \ - coreutils \ curl-dev \ g++ \ gcc \ @@ -33,22 +31,18 @@ ENV PACKAGES \ lzo-dev \ make \ mesa-dev \ - mesa-egl \ - mesa-gbm \ meson \ ncurses-dev \ - ninja \ perl \ pulseaudio-dev \ python3 \ py3-sphinx \ py3-sphinx_rtd_theme \ - shadow \ + samurai \ snappy-dev \ spice-dev \ texinfo \ usbredir-dev \ - util-linux-dev \ vde2-dev \ virglrenderer-dev \ vte3-dev \ -- 2.33.1
